Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update schema and mocked images #66

Merged
merged 4 commits into from
May 6, 2021
Merged

Update schema and mocked images #66

merged 4 commits into from
May 6, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Apr 30, 2021

Fixes #65.

This PR updates the schema.sql and mocked_images.csv files by taking a fresh pg_dump from the new PostgreSQL 13.2 container.

The dumps were generated by executing the update_mocks.sh script.

Notable differences:

  • The updated schema for the table public.image now matches the changes made to the Image model in Django.
  • The schema for the sequence public.image_id_seq is not present in the dump.
  • All the indices have changed and now have temp_ prefix and _idx1 suffix.
  • The mocked_images.csv also matches the updated schema in schema.sql.

@dhruvkb dhruvkb added this to Needs review in Openverse Apr 30, 2021
@zackkrida
Copy link
Member

Great work. It looks like the https://github.com/WordPress/openverse-api/blob/d51e38ed3b609d0f6fa668a7ef3420b556b77aa7/ingestion_server/test/mock_data/no_constraints_schema.sql is also using Postgres 10.3, could you explore that too?

@zackkrida zackkrida requested review from zackkrida and obulat May 4, 2021 19:19
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks!

Openverse automation moved this from Needs review to Reviewer approved May 5, 2021
@zackkrida zackkrida merged commit 9b3b390 into master May 6, 2021
Openverse automation moved this from Reviewer approved to Done! May 6, 2021
@zackkrida zackkrida deleted the postgres_13_dump branch May 6, 2021 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging this pull request may close these issues.

Create new db dump using Postgres 13.2 for mocks
2 participants