Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add comments to pagination and dead link mask and validation #870

Merged
merged 1 commit into from Aug 19, 2022

Conversation

sarayourfriend
Copy link
Contributor

Description

Developed in collaboration with @stacimc @obulat and @AetherUnbound.

Testing Instructions

Read the comments. We can try to further clarify things if necessary.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • [N/A] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Aug 9, 2022
@sarayourfriend sarayourfriend requested a review from a team as a code owner August 9, 2022 18:01
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/870

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼 Just one note, but fine to merge as-is.

Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is so helpful 😅 Thanks for driving this.

Openverse PRs automation moved this from Needs review to Reviewer approved Aug 11, 2022
@sarayourfriend sarayourfriend force-pushed the add/pagination-dead-link-comments branch from eba4b22 to b8e69e8 Compare August 17, 2022 16:46
@sarayourfriend sarayourfriend force-pushed the add/pagination-dead-link-comments branch from b8e69e8 to 75a18a3 Compare August 18, 2022 19:48
@sarayourfriend sarayourfriend requested a review from a team as a code owner August 18, 2022 19:48
@sarayourfriend sarayourfriend merged commit 52e47b0 into main Aug 19, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Aug 19, 2022
@sarayourfriend sarayourfriend deleted the add/pagination-dead-link-comments branch August 19, 2022 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants