Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Temporarily turn off scheduled image data refreshes, increase matview refresh timeout #1036

Merged
merged 2 commits into from Mar 8, 2023

Conversation

stacimc
Copy link
Contributor

@stacimc stacimc commented Mar 8, 2023

Description

Sets the schedule for the image data refresh to None. This allows us to keep the DAG enabled in order to do manual runs, without the weekly scheduled runs triggering. We need to do this temporarily due to ongoing issues with the popularity matview refresh, which have caused the data refresh to dramatically increase in runtime and exceed the 1-week window.

This also increases the timeout for the matview refresh step from 3 days to 6 days, after the recent run timed out once again.

Note: this PR does not touch the audio data refresh.

Testing Instructions

Pull this branch and run just up. Check that the schedule for the image data refresh is now None in the Airflow UI:
Screen Shot 2023-03-08 at 8 54 55 AM

Enable the DAG and verify that no dag run is triggered automatically. Manually trigger a DAG run, and then inspect the update_materialized_popularity_view task instance to verify that its timeout has been increased to 6 days.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Mar 8, 2023
@stacimc stacimc self-assigned this Mar 8, 2023
@stacimc stacimc requested a review from a team as a code owner March 8, 2023 16:58
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Mar 8, 2023
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much for making this change!

Openverse PRs automation moved this from Needs review to Reviewer approved Mar 8, 2023
@stacimc stacimc merged commit 6bc4e1f into main Mar 8, 2023
Openverse PRs automation moved this from Reviewer approved to Merged! Mar 8, 2023
@stacimc stacimc deleted the update/image-data-refresh-schedule-and-timeout branch March 8, 2023 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP
Projects
No open projects
Openverse
  
Awaiting triage
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants