This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Add filetype
and filesize
to SMK script
#542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
added
🟨 priority: medium
Not blocking but should be addressed soon
🌟 goal: addition
Addition of new feature
💻 aspect: code
Concerns the software code in the repository
data normalization
All the issues for normalizing the data across the stack
labels
Jun 2, 2022
10 tasks
obulat
force-pushed
the
add/smk_filetype_filesize
branch
from
June 2, 2022 18:34
36a5a8d
to
34fed9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
obulat
force-pushed
the
add/smk_filetype_filesize
branch
from
June 3, 2022 07:01
34fed9a
to
9efbc2f
Compare
obulat
force-pushed
the
add/smk_filetype_filesize
branch
3 times, most recently
from
June 6, 2022 09:53
1e5e408
to
be263ca
Compare
stacimc
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 💯
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
obulat
force-pushed
the
add/smk_filetype_filesize
branch
from
June 21, 2022 15:41
387e6c4
to
e5a2eee
Compare
1 task
AetherUnbound
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
💻 aspect: code
Concerns the software code in the repository
data normalization
All the issues for normalizing the data across the stack
🌟 goal: addition
Addition of new feature
🟨 priority: medium
Not blocking but should be addressed soon
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to WordPress/openverse#1545 by @obulat
Description
This PR adds
filetype
andfilesize
to the list of data collected from the SMK API.Testing Instructions
The tests for the script should pass.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin