Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Add filetype and filesize to SMK script #542

Merged
merged 6 commits into from Jun 22, 2022
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jun 2, 2022

Fixes

Related to WordPress/openverse#1545 by @obulat

Description

This PR adds filetype and filesize to the list of data collected from the SMK API.

Testing Instructions

The tests for the script should pass.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository data normalization All the issues for normalizing the data across the stack labels Jun 2, 2022
@obulat obulat self-assigned this Jun 2, 2022
@obulat obulat requested a review from a team as a code owner June 2, 2022 13:30
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Jun 2, 2022
@obulat obulat force-pushed the add/smk_filetype_filesize branch from 36a5a8d to 34fed9a Compare June 2, 2022 18:34
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

openverse_catalog/dags/common/extensions.py Outdated Show resolved Hide resolved
openverse_catalog/dags/common/extensions.py Outdated Show resolved Hide resolved
openverse_catalog/dags/common/extensions.py Outdated Show resolved Hide resolved
@obulat obulat force-pushed the add/smk_filetype_filesize branch from 34fed9a to 9efbc2f Compare June 3, 2022 07:01
@obulat obulat changed the base branch from main to add/extension_extraction June 3, 2022 07:02
@obulat obulat force-pushed the add/smk_filetype_filesize branch 3 times, most recently from 1e5e408 to be263ca Compare June 6, 2022 09:53
Openverse PRs automation moved this from Needs review to Reviewer approved Jun 9, 2022
Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

Base automatically changed from add/extension_extraction to main June 10, 2022 12:51
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@obulat obulat merged commit 2ae1c4d into main Jun 22, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Jun 22, 2022
@obulat obulat deleted the add/smk_filetype_filesize branch June 22, 2022 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository data normalization All the issues for normalizing the data across the stack 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants