Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Upgrade to Airflow 2.5.1, remove old warnings #985

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

AetherUnbound
Copy link
Contributor

Description

This PR upgrades Airflow to v2.5.1, which addresses an open security issue. I've also removed some warnings which we filter during testing since they are no longer raised!

Testing Instructions

  1. just build
  2. just test --extended
  3. Launch the stack and make sure you can still run a DAG

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner February 1, 2023 21:38
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Feb 1, 2023
@AetherUnbound AetherUnbound added 🟧 priority: high Stalls work on the project or its dependents 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Feb 1, 2023
Openverse PRs automation moved this from Needs review to Reviewer approved Feb 6, 2023
@AetherUnbound AetherUnbound merged commit a4afb8f into main Feb 7, 2023
Openverse PRs automation moved this from Reviewer approved to Merged! Feb 7, 2023
@AetherUnbound AetherUnbound deleted the fix/airflow-2.5.1 branch February 7, 2023 20:53
AetherUnbound added a commit that referenced this pull request Feb 25, 2023
These were removed in #985 but were actually still being issued, I had just written a very poor filter that apparently captured everything...
rwidom added a commit that referenced this pull request Feb 28, 2023
* add on failure callback

* add application name tags

* tests for on fail callback

* linting

* TEMP create_loading_table changes for testing

* TEMP add dag file for testing options

* move test file to analogous location

* helper functions and testing

* add TimedPostgresHook

* custom hook and operator

* adjust args from regression testing

* replace existing hook and operator

* migrate inaturalist to new hook and operator

* use dag exec timeout if task timeout unavailable

* add default timeout values in loader functions

* add timeouts to popularity SQL

* update report pending media

* remove pg fail tester from dag docs

* dynamic timeout for popularity mat view

* pass through task timeouts from airflow

* hard code inat batch timeout in callable

* rename sql_helpers to sql

* move happy dag fixtures to conftest

* remove separate test dag file

* remove unnecessary comments and improve style

* Add list of SQL commands and connection test

* parse execution timeout for mapped tasks

* add run_statement_timeout

* create/refresh popularity = separate, remove to do

* inat load_transformed_data at default timeout

* update loader param descriptions to task

* add doc string for hook.run_statement_timeout

* Update openverse_catalog/dags/database/image_expiration_workflow.py

Co-authored-by: Staci Mullins <63313398+stacimc@users.noreply.github.com>

* rename mock task and dag fixtures

* use kwargs in popularity metrics task factory

* replace op_args with op_kwargs in task factories

* PostgresHook.get_execution_timeout handles None

* Re-order parameters so task is optional

* Re-add old warnings capture, add new warning

These were removed in #985 but were actually still being issued, I had just written a very poor filter that apparently captured everything...

* Tweak docs & warning message

* Also fix test associated with log message

* Add happy path dag test to extended tests

This just improves testing speeds for most test runs, full suite runs will happen in CI/CD

* Use AbstractOperator to include mapped & base

---------

Co-authored-by: Staci Mullins <63313398+stacimc@users.noreply.github.com>
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants