Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fixed positioning of the sidebar breaks license popover placement #1413

Closed
zackkrida opened this issue May 11, 2022 · 2 comments · Fixed by #1415
Closed

Fixed positioning of the sidebar breaks license popover placement #1413

zackkrida opened this issue May 11, 2022 · 2 comments · Fixed by #1415
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects

Comments

@zackkrida
Copy link
Member

zackkrida commented May 11, 2022

Description

The placement of the license popovers is shifted slightly to fit within the bounds of the sidebar now that it is fixed position:

CleanShot 2022-05-11 at 12 44 04@2x

This feels odd—the popover shouldn't care about the filter sidebar's positioning and should be positioned relative to the document, I would think.

Reproduction

  1. Run openverse locally on main and submit a search
  2. Click any license popover icon in the filter sidebar
  3. Observe the odd placement in the screenshot above
@zackkrida zackkrida added 🟨 priority: medium Not blocking but should be addressed soon 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix labels May 11, 2022
@openverse-bot openverse-bot added this to Backlog in Openverse May 11, 2022
@sarayourfriend
Copy link
Contributor

There are some popper.js flags we can manipulate to solve this (I think).

That line might be of particular interest.

@AetherUnbound AetherUnbound added 🕹 aspect: interface Concerns end-users' experience with the software and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels May 11, 2022
@zackkrida
Copy link
Member Author

Thanks @sarayourfriend, yes children of fixed elements need to use the fixed strategy. PR incoming.

@openverse-bot openverse-bot moved this from Backlog to In progress in Openverse May 11, 2022
Openverse automation moved this from In progress to Done! May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging a pull request may close this issue.

3 participants