Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Make the popover positioning strategy configurable #1415

Merged
merged 3 commits into from May 11, 2022
Merged

Make the popover positioning strategy configurable #1415

merged 3 commits into from May 11, 2022

Conversation

zackkrida
Copy link
Member

Fixes

Fixes #1413 by @zackkrida

Description

Makes the popper.js property 'positioning strategy' configurable; sets this property to 'fixed' for the elements in the filter sidebar.

Testing Instructions

  • Inspect the styles for the license explanation popover and look for position: fixed in the inline CSS.
  • Inspect the styles for the single result reporting form popover and look for position: absolute in the inline CSS.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner May 11, 2022 18:59
@zackkrida zackkrida requested review from krysal and dhruvkb May 11, 2022 18:59
@openverse-bot openverse-bot added this to Needs review in Openverse PRs May 11, 2022
@github-actions
Copy link

github-actions bot commented May 11, 2022 •
edited

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/1415
Tailwind: https://wordpress.github.io/openverse-frontend/1415/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon labels May 11, 2022
@github-actions
Copy link

github-actions bot commented May 11, 2022 •
edited

Size Change: +111 B (0%)

Total Size: 1.4 MB

Filename Size Change
./.nuxt/dist/client/app.js 109 kB +61 B (0%)
./.nuxt/dist/client/app.modern.js 102 kB +55 B (0%)
./.nuxt/dist/client/pages/meta-search.js 1.67 kB -3 B (0%)
./.nuxt/dist/client/pages/meta-search.modern.js 1.67 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
./.nuxt/dist/client/235.js 273 B
./.nuxt/dist/client/235.modern.js 277 B
./.nuxt/dist/client/236.js 1.85 kB
./.nuxt/dist/client/commons/app.js 83.1 kB
./.nuxt/dist/client/commons/app.modern.js 71.9 kB
./.nuxt/dist/client/components/extension-browsers.js 816 B
./.nuxt/dist/client/components/extension-browsers.modern.js 821 B
./.nuxt/dist/client/components/loading-icon.js 766 B
./.nuxt/dist/client/components/loading-icon.modern.js 774 B
./.nuxt/dist/client/components/table-sort-icon.js 515 B
./.nuxt/dist/client/components/table-sort-icon.modern.js 519 B
./.nuxt/dist/client/components/v-all-results-grid.js 4.16 kB
./.nuxt/dist/client/components/v-all-results-grid.modern.js 4.02 kB
./.nuxt/dist/client/components/v-audio-cell.js 341 B
./.nuxt/dist/client/components/v-audio-cell.modern.js 346 B
./.nuxt/dist/client/components/v-audio-details.js 1.56 kB
./.nuxt/dist/client/components/v-audio-details.modern.js 1.56 kB
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1 kB
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1 kB
./.nuxt/dist/client/components/v-audio-track.js 4.47 kB
./.nuxt/dist/client/components/v-audio-track.modern.js 4.45 kB
./.nuxt/dist/client/components/v-back-to-search-results-link.js 576 B
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 579 B
./.nuxt/dist/client/components/v-bone.js 682 B
./.nuxt/dist/client/components/v-bone.modern.js 688 B
./.nuxt/dist/client/components/v-box-layout.js 1.2 kB
./.nuxt/dist/client/components/v-box-layout.modern.js 1.2 kB
./.nuxt/dist/client/components/v-content-link.js 1.06 kB
./.nuxt/dist/client/components/v-content-link.modern.js 1.04 kB
./.nuxt/dist/client/components/v-content-page.js 460 B
./.nuxt/dist/client/components/v-content-page.modern.js 465 B
./.nuxt/dist/client/components/v-content-report-button.js 776 B
./.nuxt/dist/client/components/v-content-report-button.modern.js 780 B
./.nuxt/dist/client/components/v-content-report-form.js 3.77 kB
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.58 kB
./.nuxt/dist/client/components/v-content-report-popover.js 4.43 kB
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.25 kB
./.nuxt/dist/client/components/v-copy-button.js 3.94 kB
./.nuxt/dist/client/components/v-copy-button.modern.js 3.95 kB
./.nuxt/dist/client/components/v-copy-license.js 4.1 kB
./.nuxt/dist/client/components/v-copy-license.modern.js 4.05 kB
./.nuxt/dist/client/components/v-dmca-notice.js 752 B
./.nuxt/dist/client/components/v-dmca-notice.modern.js 759 B
./.nuxt/dist/client/components/v-error-image.js 2.66 kB
./.nuxt/dist/client/components/v-error-image.modern.js 2.62 kB
./.nuxt/dist/client/components/v-error-section.js 386 B
./.nuxt/dist/client/components/v-error-section.modern.js 391 B
./.nuxt/dist/client/components/v-full-layout.js 1.52 kB
./.nuxt/dist/client/components/v-full-layout.modern.js 1.52 kB
./.nuxt/dist/client/components/v-grid-skeleton.js 1.64 kB
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.64 kB
./.nuxt/dist/client/components/v-image-cell-square.js 1.01 kB
./.nuxt/dist/client/components/v-image-cell-square.modern.js 1.01 kB
./.nuxt/dist/client/components/v-image-cell.js 1.48 kB
./.nuxt/dist/client/components/v-image-cell.modern.js 1.47 kB
./.nuxt/dist/client/components/v-image-details.js 1.45 kB
./.nuxt/dist/client/components/v-image-details.modern.js 1.45 kB
./.nuxt/dist/client/components/v-image-grid.js 2.61 kB
./.nuxt/dist/client/components/v-image-grid.modern.js 2.5 kB
./.nuxt/dist/client/components/v-license-tab-panel.js 922 B
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 917 B
./.nuxt/dist/client/components/v-load-more.js 768 B
./.nuxt/dist/client/components/v-load-more.modern.js 665 B
./.nuxt/dist/client/components/v-media-license.js 807 B
./.nuxt/dist/client/components/v-media-license.modern.js 816 B
./.nuxt/dist/client/components/v-media-reuse.js 1.04 kB
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.05 kB
./.nuxt/dist/client/components/v-media-tag.js 422 B
./.nuxt/dist/client/components/v-media-tag.modern.js 426 B
./.nuxt/dist/client/components/v-meta-search-form.js 3.02 kB
./.nuxt/dist/client/components/v-meta-search-form.modern.js 2.99 kB
./.nuxt/dist/client/components/v-meta-source-list.js 2.3 kB
./.nuxt/dist/client/components/v-meta-source-list.modern.js 2.29 kB
./.nuxt/dist/client/components/v-modal.js 877 B
./.nuxt/dist/client/components/v-modal.modern.js 881 B
./.nuxt/dist/client/components/v-no-results.js 2.5 kB
./.nuxt/dist/client/components/v-no-results.modern.js 2.49 kB
./.nuxt/dist/client/components/v-radio.js 1.53 kB
./.nuxt/dist/client/components/v-radio.modern.js 1.48 kB
./.nuxt/dist/client/components/v-related-audio.js 1.25 kB
./.nuxt/dist/client/components/v-related-audio.modern.js 1.25 kB
./.nuxt/dist/client/components/v-related-images.js 2.76 kB
./.nuxt/dist/client/components/v-related-images.modern.js 2.65 kB
./.nuxt/dist/client/components/v-report-desc-form.js 958 B
./.nuxt/dist/client/components/v-report-desc-form.modern.js 961 B
./.nuxt/dist/client/components/v-row-layout.js 1.81 kB
./.nuxt/dist/client/components/v-row-layout.modern.js 1.81 kB
./.nuxt/dist/client/components/v-scroll-button.js 800 B
./.nuxt/dist/client/components/v-scroll-button.modern.js 808 B
./.nuxt/dist/client/components/v-search-grid.js 6.25 kB
./.nuxt/dist/client/components/v-search-grid.modern.js 6.18 kB
./.nuxt/dist/client/components/v-search-results-title.js 664 B
./.nuxt/dist/client/components/v-search-results-title.modern.js 657 B
./.nuxt/dist/client/components/v-search-type-radio.js 831 B
./.nuxt/dist/client/components/v-search-type-radio.modern.js 821 B
./.nuxt/dist/client/components/v-server-timeout.js 315 B
./.nuxt/dist/client/components/v-server-timeout.modern.js 319 B
./.nuxt/dist/client/components/v-sidebar-content.js 446 B
./.nuxt/dist/client/components/v-sidebar-content.modern.js 447 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 997 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 895 B
./.nuxt/dist/client/components/v-skip-to-content-container.js 900 B
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 905 B
./.nuxt/dist/client/components/v-sources-table.js 14.3 kB
./.nuxt/dist/client/components/v-sources-table.modern.js 14.3 kB
./.nuxt/dist/client/components/v-tab-panel.js 689 B
./.nuxt/dist/client/components/v-tab-panel.modern.js 685 B
./.nuxt/dist/client/components/v-tab.js 1.77 kB
./.nuxt/dist/client/components/v-tab.modern.js 1.77 kB
./.nuxt/dist/client/components/v-tabs.js 754 B
./.nuxt/dist/client/components/v-tabs.modern.js 742 B
./.nuxt/dist/client/components/v-warning-suppressor.js 301 B
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 305 B
./.nuxt/dist/client/lang-af.json.js 147 B
./.nuxt/dist/client/lang-af.json.modern.js 154 B
./.nuxt/dist/client/lang-am.json.js 147 B
./.nuxt/dist/client/lang-am.json.modern.js 154 B
./.nuxt/dist/client/lang-an.json.js 147 B
./.nuxt/dist/client/lang-an.json.modern.js 153 B
./.nuxt/dist/client/lang-ar.json.js 251 B
./.nuxt/dist/client/lang-ar.json.modern.js 255 B
./.nuxt/dist/client/lang-arq.json.js 148 B
./.nuxt/dist/client/lang-arq.json.modern.js 155 B
./.nuxt/dist/client/lang-ary.json.js 148 B
./.nuxt/dist/client/lang-ary.json.modern.js 155 B
./.nuxt/dist/client/lang-as.json.js 147 B
./.nuxt/dist/client/lang-as.json.modern.js 154 B
./.nuxt/dist/client/lang-az-tr.json.js 150 B
./.nuxt/dist/client/lang-az-tr.json.modern.js 157 B
./.nuxt/dist/client/lang-az.json.js 147 B
./.nuxt/dist/client/lang-az.json.modern.js 154 B
./.nuxt/dist/client/lang-azb.json.js 148 B
./.nuxt/dist/client/lang-azb.json.modern.js 155 B
./.nuxt/dist/client/lang-ba.json.js 147 B
./.nuxt/dist/client/lang-ba.json.modern.js 154 B
./.nuxt/dist/client/lang-bel.json.js 148 B
./.nuxt/dist/client/lang-bel.json.modern.js 155 B
./.nuxt/dist/client/lang-bg.json.js 147 B
./.nuxt/dist/client/lang-bg.json.modern.js 154 B
./.nuxt/dist/client/lang-bn-in.json.js 150 B
./.nuxt/dist/client/lang-bn-in.json.modern.js 156 B
./.nuxt/dist/client/lang-bn.json.js 147 B
./.nuxt/dist/client/lang-bn.json.modern.js 153 B
./.nuxt/dist/client/lang-bo.json.js 147 B
./.nuxt/dist/client/lang-bo.json.modern.js 154 B
./.nuxt/dist/client/lang-br.json.js 147 B
./.nuxt/dist/client/lang-br.json.modern.js 154 B
./.nuxt/dist/client/lang-bs.json.js 147 B
./.nuxt/dist/client/lang-bs.json.modern.js 154 B
./.nuxt/dist/client/lang-ca.json.js 9.3 kB
./.nuxt/dist/client/lang-ca.json.modern.js 9.3 kB
./.nuxt/dist/client/lang-ckb.json.js 148 B
./.nuxt/dist/client/lang-ckb.json.modern.js 155 B
./.nuxt/dist/client/lang-co.json.js 147 B
./.nuxt/dist/client/lang-co.json.modern.js 154 B
./.nuxt/dist/client/lang-cor.json.js 148 B
./.nuxt/dist/client/lang-cor.json.modern.js 155 B
./.nuxt/dist/client/lang-cs.json.js 9.71 kB
./.nuxt/dist/client/lang-cs.json.modern.js 9.72 kB
./.nuxt/dist/client/lang-cy.json.js 9.4 kB
./.nuxt/dist/client/lang-cy.json.modern.js 9.41 kB
./.nuxt/dist/client/lang-da.json.js 8.72 kB
./.nuxt/dist/client/lang-da.json.modern.js 8.72 kB
./.nuxt/dist/client/lang-de-at.json.js 150 B
./.nuxt/dist/client/lang-de-at.json.modern.js 157 B
./.nuxt/dist/client/lang-de-ch.json.js 150 B
./.nuxt/dist/client/lang-de-ch.json.modern.js 157 B
./.nuxt/dist/client/lang-de.json.js 10 kB
./.nuxt/dist/client/lang-de.json.modern.js 10 kB
./.nuxt/dist/client/lang-dv.json.js 147 B
./.nuxt/dist/client/lang-dv.json.modern.js 154 B
./.nuxt/dist/client/lang-dzo.json.js 148 B
./.nuxt/dist/client/lang-dzo.json.modern.js 155 B
./.nuxt/dist/client/lang-el.json.js 11.5 kB
./.nuxt/dist/client/lang-el.json.modern.js 11.5 kB
./.nuxt/dist/client/lang-en-au.json.js 810 B
./.nuxt/dist/client/lang-en-au.json.modern.js 813 B
./.nuxt/dist/client/lang-en-ca.json.js 7.91 kB
./.nuxt/dist/client/lang-en-ca.json.modern.js 7.91 kB
./.nuxt/dist/client/lang-en-gb.json.js 8.59 kB
./.nuxt/dist/client/lang-en-gb.json.modern.js 8.59 kB
./.nuxt/dist/client/lang-en-nz.json.js 150 B
./.nuxt/dist/client/lang-en-nz.json.modern.js 157 B
./.nuxt/dist/client/lang-en-za.json.js 5.22 kB
./.nuxt/dist/client/lang-en-za.json.modern.js 5.23 kB
./.nuxt/dist/client/lang-en.json.js 8.47 kB
./.nuxt/dist/client/lang-en.json.modern.js 8.47 kB
./.nuxt/dist/client/lang-eo.json.js 147 B
./.nuxt/dist/client/lang-eo.json.modern.js 154 B
./.nuxt/dist/client/lang-es-ar.json.js 8.9 kB
./.nuxt/dist/client/lang-es-ar.json.modern.js 8.9 kB
./.nuxt/dist/client/lang-es-cl.json.js 150 B
./.nuxt/dist/client/lang-es-cl.json.modern.js 157 B
./.nuxt/dist/client/lang-es-co.json.js 9.11 kB
./.nuxt/dist/client/lang-es-co.json.modern.js 9.12 kB
./.nuxt/dist/client/lang-es-cr.json.js 150 B
./.nuxt/dist/client/lang-es-cr.json.modern.js 157 B
./.nuxt/dist/client/lang-es-do.json.js 5.01 kB
./.nuxt/dist/client/lang-es-do.json.modern.js 5.02 kB
./.nuxt/dist/client/lang-es-ec.json.js 9.11 kB
./.nuxt/dist/client/lang-es-ec.json.modern.js 9.12 kB
./.nuxt/dist/client/lang-es-gt.json.js 151 B
./.nuxt/dist/client/lang-es-gt.json.modern.js 158 B
./.nuxt/dist/client/lang-es-hn.json.js 151 B
./.nuxt/dist/client/lang-es-hn.json.modern.js 157 B
./.nuxt/dist/client/lang-es-mx.json.js 9.32 kB
./.nuxt/dist/client/lang-es-mx.json.modern.js 9.32 kB
./.nuxt/dist/client/lang-es-pe.json.js 151 B
./.nuxt/dist/client/lang-es-pe.json.modern.js 158 B
./.nuxt/dist/client/lang-es-pr.json.js 151 B
./.nuxt/dist/client/lang-es-pr.json.modern.js 158 B
./.nuxt/dist/client/lang-es-uy.json.js 151 B
./.nuxt/dist/client/lang-es-uy.json.modern.js 158 B
./.nuxt/dist/client/lang-es-ve.json.js 9.12 kB
./.nuxt/dist/client/lang-es-ve.json.modern.js 9.12 kB
./.nuxt/dist/client/lang-es.json.js 9.33 kB
./.nuxt/dist/client/lang-es.json.modern.js 9.34 kB
./.nuxt/dist/client/lang-et.json.js 148 B
./.nuxt/dist/client/lang-et.json.modern.js 155 B
./.nuxt/dist/client/lang-eu.json.js 148 B
./.nuxt/dist/client/lang-eu.json.modern.js 155 B
./.nuxt/dist/client/lang-fa-af.json.js 151 B
./.nuxt/dist/client/lang-fa-af.json.modern.js 158 B
./.nuxt/dist/client/lang-fa.json.js 3.05 kB
./.nuxt/dist/client/lang-fa.json.modern.js 3.05 kB
./.nuxt/dist/client/lang-fi.json.js 148 B
./.nuxt/dist/client/lang-fi.json.modern.js 155 B
./.nuxt/dist/client/lang-fo.json.js 148 B
./.nuxt/dist/client/lang-fo.json.modern.js 155 B
./.nuxt/dist/client/lang-fr-be.json.js 151 B
./.nuxt/dist/client/lang-fr-be.json.modern.js 158 B
./.nuxt/dist/client/lang-fr-ca.json.js 151 B
./.nuxt/dist/client/lang-fr-ca.json.modern.js 158 B
./.nuxt/dist/client/lang-fr.json.js 7.1 kB
./.nuxt/dist/client/lang-fr.json.modern.js 7.1 kB
./.nuxt/dist/client/lang-fuc.json.js 149 B
./.nuxt/dist/client/lang-fuc.json.modern.js 156 B
./.nuxt/dist/client/lang-fy.json.js 148 B
./.nuxt/dist/client/lang-fy.json.modern.js 155 B
./.nuxt/dist/client/lang-ga.json.js 148 B
./.nuxt/dist/client/lang-ga.json.modern.js 155 B
./.nuxt/dist/client/lang-gd.json.js 148 B
./.nuxt/dist/client/lang-gd.json.modern.js 155 B
./.nuxt/dist/client/lang-gl.json.js 9.17 kB
./.nuxt/dist/client/lang-gl.json.modern.js 9.18 kB
./.nuxt/dist/client/lang-gu.json.js 148 B
./.nuxt/dist/client/lang-gu.json.modern.js 155 B
./.nuxt/dist/client/lang-hat.json.js 149 B
./.nuxt/dist/client/lang-hat.json.modern.js 156 B
./.nuxt/dist/client/lang-hau.json.js 149 B
./.nuxt/dist/client/lang-hau.json.modern.js 156 B
./.nuxt/dist/client/lang-he.json.js 148 B
./.nuxt/dist/client/lang-he.json.modern.js 155 B
./.nuxt/dist/client/lang-hi.json.js 204 B
./.nuxt/dist/client/lang-hi.json.modern.js 210 B
./.nuxt/dist/client/lang-hr.json.js 148 B
./.nuxt/dist/client/lang-hr.json.modern.js 155 B
./.nuxt/dist/client/lang-hu.json.js 148 B
./.nuxt/dist/client/lang-hu.json.modern.js 155 B
./.nuxt/dist/client/lang-hy.json.js 148 B
./.nuxt/dist/client/lang-hy.json.modern.js 155 B
./.nuxt/dist/client/lang-ibo.json.js 149 B
./.nuxt/dist/client/lang-ibo.json.modern.js 156 B
./.nuxt/dist/client/lang-id.json.js 8.45 kB
./.nuxt/dist/client/lang-id.json.modern.js 8.46 kB
./.nuxt/dist/client/lang-ido.json.js 149 B
./.nuxt/dist/client/lang-ido.json.modern.js 156 B
./.nuxt/dist/client/lang-is.json.js 148 B
./.nuxt/dist/client/lang-is.json.modern.js 155 B
./.nuxt/dist/client/lang-it.json.js 9.13 kB
./.nuxt/dist/client/lang-it.json.modern.js 9.13 kB
./.nuxt/dist/client/lang-ja.json.js 4.72 kB
./.nuxt/dist/client/lang-ja.json.modern.js 4.72 kB
./.nuxt/dist/client/lang-jv.json.js 148 B
./.nuxt/dist/client/lang-jv.json.modern.js 155 B
./.nuxt/dist/client/lang-ka.json.js 148 B
./.nuxt/dist/client/lang-ka.json.modern.js 155 B
./.nuxt/dist/client/lang-kal.json.js 149 B
./.nuxt/dist/client/lang-kal.json.modern.js 156 B
./.nuxt/dist/client/lang-kin.json.js 149 B
./.nuxt/dist/client/lang-kin.json.modern.js 155 B
./.nuxt/dist/client/lang-kir.json.js 907 B
./.nuxt/dist/client/lang-kir.json.modern.js 911 B
./.nuxt/dist/client/lang-kk.json.js 148 B
./.nuxt/dist/client/lang-kk.json.modern.js 155 B
./.nuxt/dist/client/lang-km.json.js 148 B
./.nuxt/dist/client/lang-km.json.modern.js 155 B
./.nuxt/dist/client/lang-kmr.json.js 149 B
./.nuxt/dist/client/lang-kmr.json.modern.js 156 B
./.nuxt/dist/client/lang-kn.json.js 3.28 kB
./.nuxt/dist/client/lang-kn.json.modern.js 3.28 kB
./.nuxt/dist/client/lang-ko.json.js 148 B
./.nuxt/dist/client/lang-ko.json.modern.js 155 B
./.nuxt/dist/client/lang-lb.json.js 148 B
./.nuxt/dist/client/lang-lb.json.modern.js 155 B
./.nuxt/dist/client/lang-li.json.js 148 B
./.nuxt/dist/client/lang-li.json.modern.js 155 B
./.nuxt/dist/client/lang-lin.json.js 149 B
./.nuxt/dist/client/lang-lin.json.modern.js 155 B
./.nuxt/dist/client/lang-lo.json.js 148 B
./.nuxt/dist/client/lang-lo.json.modern.js 155 B
./.nuxt/dist/client/lang-lt.json.js 148 B
./.nuxt/dist/client/lang-lt.json.modern.js 155 B
./.nuxt/dist/client/lang-lug.json.js 149 B
./.nuxt/dist/client/lang-lug.json.modern.js 156 B
./.nuxt/dist/client/lang-lv.json.js 6.73 kB
./.nuxt/dist/client/lang-lv.json.modern.js 6.73 kB
./.nuxt/dist/client/lang-mg.json.js 148 B
./.nuxt/dist/client/lang-mg.json.modern.js 155 B
./.nuxt/dist/client/lang-mk.json.js 148 B
./.nuxt/dist/client/lang-mk.json.modern.js 155 B
./.nuxt/dist/client/lang-ml.json.js 148 B
./.nuxt/dist/client/lang-ml.json.modern.js 155 B
./.nuxt/dist/client/lang-mn.json.js 148 B
./.nuxt/dist/client/lang-mn.json.modern.js 154 B
./.nuxt/dist/client/lang-mr.json.js 148 B
./.nuxt/dist/client/lang-mr.json.modern.js 155 B
./.nuxt/dist/client/lang-mri.json.js 149 B
./.nuxt/dist/client/lang-mri.json.modern.js 156 B
./.nuxt/dist/client/lang-ms.json.js 148 B
./.nuxt/dist/client/lang-ms.json.modern.js 155 B
./.nuxt/dist/client/lang-mya.json.js 149 B
./.nuxt/dist/client/lang-mya.json.modern.js 156 B
./.nuxt/dist/client/lang-nb.json.js 3.36 kB
./.nuxt/dist/client/lang-nb.json.modern.js 3.37 kB
./.nuxt/dist/client/lang-ne.json.js 330 B
./.nuxt/dist/client/lang-ne.json.modern.js 335 B
./.nuxt/dist/client/lang-nl-be.json.js 9.42 kB
./.nuxt/dist/client/lang-nl-be.json.modern.js 9.43 kB
./.nuxt/dist/client/lang-nl.json.js 6.47 kB
./.nuxt/dist/client/lang-nl.json.modern.js 6.47 kB
./.nuxt/dist/client/lang-nn.json.js 148 B
./.nuxt/dist/client/lang-nn.json.modern.js 154 B
./.nuxt/dist/client/lang-oci.json.js 149 B
./.nuxt/dist/client/lang-oci.json.modern.js 156 B
./.nuxt/dist/client/lang-ory.json.js 149 B
./.nuxt/dist/client/lang-ory.json.modern.js 156 B
./.nuxt/dist/client/lang-os.json.js 148 B
./.nuxt/dist/client/lang-os.json.modern.js 155 B
./.nuxt/dist/client/lang-pl.json.js 148 B
./.nuxt/dist/client/lang-pl.json.modern.js 155 B
./.nuxt/dist/client/lang-ps.json.js 148 B
./.nuxt/dist/client/lang-ps.json.modern.js 155 B
./.nuxt/dist/client/lang-pt-ao.json.js 151 B
./.nuxt/dist/client/lang-pt-ao.json.modern.js 157 B
./.nuxt/dist/client/lang-pt-br.json.js 5.59 kB
./.nuxt/dist/client/lang-pt-br.json.modern.js 5.59 kB
./.nuxt/dist/client/lang-pt.json.js 433 B
./.nuxt/dist/client/lang-pt.json.modern.js 438 B
./.nuxt/dist/client/lang-ro.json.js 9.55 kB
./.nuxt/dist/client/lang-ro.json.modern.js 9.56 kB
./.nuxt/dist/client/lang-roh.json.js 149 B
./.nuxt/dist/client/lang-roh.json.modern.js 156 B
./.nuxt/dist/client/lang-ru.json.js 3.66 kB
./.nuxt/dist/client/lang-ru.json.modern.js 3.66 kB
./.nuxt/dist/client/lang-sa-in.json.js 151 B
./.nuxt/dist/client/lang-sa-in.json.modern.js 157 B
./.nuxt/dist/client/lang-si.json.js 148 B
./.nuxt/dist/client/lang-si.json.modern.js 155 B
./.nuxt/dist/client/lang-sk.json.js 268 B
./.nuxt/dist/client/lang-sk.json.modern.js 271 B
./.nuxt/dist/client/lang-sl.json.js 148 B
./.nuxt/dist/client/lang-sl.json.modern.js 155 B
./.nuxt/dist/client/lang-sna.json.js 149 B
./.nuxt/dist/client/lang-sna.json.modern.js 156 B
./.nuxt/dist/client/lang-snd.json.js 149 B
./.nuxt/dist/client/lang-snd.json.modern.js 156 B
./.nuxt/dist/client/lang-so.json.js 148 B
./.nuxt/dist/client/lang-so.json.modern.js 155 B
./.nuxt/dist/client/lang-sq-xk.json.js 151 B
./.nuxt/dist/client/lang-sq-xk.json.modern.js 158 B
./.nuxt/dist/client/lang-sq.json.js 9.77 kB
./.nuxt/dist/client/lang-sq.json.modern.js 9.78 kB
./.nuxt/dist/client/lang-sr.json.js 148 B
./.nuxt/dist/client/lang-sr.json.modern.js 155 B
./.nuxt/dist/client/lang-srd.json.js 149 B
./.nuxt/dist/client/lang-srd.json.modern.js 156 B
./.nuxt/dist/client/lang-ssw.json.js 149 B
./.nuxt/dist/client/lang-ssw.json.modern.js 155 B
./.nuxt/dist/client/lang-su.json.js 148 B
./.nuxt/dist/client/lang-su.json.modern.js 155 B
./.nuxt/dist/client/lang-sv.json.js 4.92 kB
./.nuxt/dist/client/lang-sv.json.modern.js 4.93 kB
./.nuxt/dist/client/lang-sw.json.js 148 B
./.nuxt/dist/client/lang-sw.json.modern.js 155 B
./.nuxt/dist/client/lang-ta-lk.json.js 151 B
./.nuxt/dist/client/lang-ta-lk.json.modern.js 158 B
./.nuxt/dist/client/lang-ta.json.js 148 B
./.nuxt/dist/client/lang-ta.json.modern.js 155 B
./.nuxt/dist/client/lang-tah.json.js 149 B
./.nuxt/dist/client/lang-tah.json.modern.js 156 B
./.nuxt/dist/client/lang-te.json.js 3.52 kB
./.nuxt/dist/client/lang-te.json.modern.js 3.53 kB
./.nuxt/dist/client/lang-tg.json.js 148 B
./.nuxt/dist/client/lang-tg.json.modern.js 155 B
./.nuxt/dist/client/lang-th.json.js 148 B
./.nuxt/dist/client/lang-th.json.modern.js 155 B
./.nuxt/dist/client/lang-tir.json.js 149 B
./.nuxt/dist/client/lang-tir.json.modern.js 156 B
./.nuxt/dist/client/lang-tl.json.js 148 B
./.nuxt/dist/client/lang-tl.json.modern.js 155 B
./.nuxt/dist/client/lang-tr.json.js 1.38 kB
./.nuxt/dist/client/lang-tr.json.modern.js 1.39 kB
./.nuxt/dist/client/lang-tt.json.js 148 B
./.nuxt/dist/client/lang-tt.json.modern.js 155 B
./.nuxt/dist/client/lang-tuk.json.js 149 B
./.nuxt/dist/client/lang-tuk.json.modern.js 156 B
./.nuxt/dist/client/lang-ug.json.js 148 B
./.nuxt/dist/client/lang-ug.json.modern.js 155 B
./.nuxt/dist/client/lang-uk.json.js 148 B
./.nuxt/dist/client/lang-uk.json.modern.js 155 B
./.nuxt/dist/client/lang-ur.json.js 148 B
./.nuxt/dist/client/lang-ur.json.modern.js 155 B
./.nuxt/dist/client/lang-uz.json.js 148 B
./.nuxt/dist/client/lang-uz.json.modern.js 155 B
./.nuxt/dist/client/lang-vi.json.js 148 B
./.nuxt/dist/client/lang-vi.json.modern.js 155 B
./.nuxt/dist/client/lang-wol.json.js 149 B
./.nuxt/dist/client/lang-wol.json.modern.js 156 B
./.nuxt/dist/client/lang-xho.json.js 149 B
./.nuxt/dist/client/lang-xho.json.modern.js 156 B
./.nuxt/dist/client/lang-yor.json.js 149 B
./.nuxt/dist/client/lang-yor.json.modern.js 156 B
./.nuxt/dist/client/lang-zh-cn.json.js 5.04 kB
./.nuxt/dist/client/lang-zh-cn.json.modern.js 5.05 kB
./.nuxt/dist/client/lang-zh-hk.json.js 151 B
./.nuxt/dist/client/lang-zh-hk.json.modern.js 158 B
./.nuxt/dist/client/lang-zh-sg.json.js 151 B
./.nuxt/dist/client/lang-zh-sg.json.modern.js 158 B
./.nuxt/dist/client/lang-zh-tw.json.js 4.1 kB
./.nuxt/dist/client/lang-zh-tw.json.modern.js 4.1 kB
./.nuxt/dist/client/lang-zul.json.js 149 B
./.nuxt/dist/client/lang-zul.json.modern.js 156 B
./.nuxt/dist/client/pages/about.js 1.05 kB
./.nuxt/dist/client/pages/about.modern.js 1.05 kB
./.nuxt/dist/client/pages/audio/_id.js 4.05 kB
./.nuxt/dist/client/pages/audio/_id.modern.js 3.93 kB
./.nuxt/dist/client/pages/extension.js 2.19 kB
./.nuxt/dist/client/pages/extension.modern.js 2.2 kB
./.nuxt/dist/client/pages/feedback.js 3.25 kB
./.nuxt/dist/client/pages/feedback.modern.js 3.22 kB
./.nuxt/dist/client/pages/image/_id.js 6.49 kB
./.nuxt/dist/client/pages/image/_id.modern.js 6.28 kB
./.nuxt/dist/client/pages/index.js 5.08 kB
./.nuxt/dist/client/pages/index.modern.js 4.95 kB
./.nuxt/dist/client/pages/preferences.js 1.24 kB
./.nuxt/dist/client/pages/preferences.modern.js 1.24 kB
./.nuxt/dist/client/pages/search-help.js 1.53 kB
./.nuxt/dist/client/pages/search-help.modern.js 1.53 kB
./.nuxt/dist/client/pages/search.js 2.6 kB
./.nuxt/dist/client/pages/search.modern.js 2.48 kB
./.nuxt/dist/client/pages/search/audio.js 2.85 kB
./.nuxt/dist/client/pages/search/audio.modern.js 2.73 kB
./.nuxt/dist/client/pages/search/image.js 2.99 kB
./.nuxt/dist/client/pages/search/image.modern.js 2.86 kB
./.nuxt/dist/client/pages/search/index.js 807 B
./.nuxt/dist/client/pages/search/index.modern.js 718 B
./.nuxt/dist/client/pages/search/search-page.types.js 266 B
./.nuxt/dist/client/pages/search/search-page.types.modern.js 270 B
./.nuxt/dist/client/pages/search/video.js 257 B
./.nuxt/dist/client/pages/search/video.modern.js 261 B
./.nuxt/dist/client/pages/sources.js 1.43 kB
./.nuxt/dist/client/pages/sources.modern.js 1.43 kB
./.nuxt/dist/client/runtime.js 2.7 kB
./.nuxt/dist/client/runtime.modern.js 2.7 kB
./.nuxt/dist/client/vendors/app.js 49 kB
./.nuxt/dist/client/vendors/app.modern.js 48.4 kB
./.nuxt/dist/client/vendors/sentry.js 41.5 kB
./.nuxt/dist/client/vendors/sentry.modern.js 41.5 kB

compressed-size-action

sarayourfriend
sarayourfriend approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested well locally. Thanks.

krysal
krysal approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Openverse PRs automation moved this from Needs review to Reviewer approved May 11, 2022
@zackkrida zackkrida merged commit b0565a1 into main May 11, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! May 11, 2022
@zackkrida zackkrida deleted the fix-licence-info-popover-placement branch May 11, 2022 21:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krysal krysal krysal approved these changes

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@dhruvkb dhruvkb Awaiting requested review from dhruvkb dhruvkb is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse PRs
  
Merged!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixed positioning of the sidebar breaks license popover placement
4 participants
@zackkrida @krysal @sarayourfriend @openverse-bot