Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[Feature] Waveform timestamp is cut off at the start of the audio track #150

Closed
1 task
Tracked by #118
sarayourfriend opened this issue Aug 23, 2021 · 0 comments · Fixed by #156
Closed
1 task
Tracked by #118

[Feature] Waveform timestamp is cut off at the start of the audio track #150

sarayourfriend opened this issue Aug 23, 2021 · 0 comments · Fixed by #156
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@sarayourfriend
Copy link
Contributor

Problem

The timestamp is not visible at the start of the audio track.

Description

The timestamp gets cut off at the beginning of the audio:

Captura de Tela 2021-08-23 às 13 21 38

(Note the cut off "2")

We should make it so that the timestamp "flips" sides at the start of the audio track until there's enough space for it to correctly appear to the left hand side.

Alternatively we could move the timestamp to the top of the waveform, above it, so that it isn't cut off by the bounding box of the waveform (but this would be a pretty different implementation and making it line up correctly would be hard I think).

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Aug 23, 2021
@zackkrida zackkrida added good first issue New-contributor friendly help wanted Open to participation from the community and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 23, 2021
@zackkrida zackkrida mentioned this issue Aug 23, 2021
15 tasks
@dhruvkb dhruvkb self-assigned this Aug 24, 2021
@dhruvkb dhruvkb linked a pull request Aug 30, 2021 that will close this issue
7 tasks
@dhruvkb dhruvkb closed this as completed Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants