Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different components in storybook and the staging site (audio box) #538

Closed
1 task
fcoveram opened this issue Jul 11, 2022 · 3 comments
Closed
1 task

Different components in storybook and the staging site (audio box) #538

fcoveram opened this issue Jul 11, 2022 · 3 comments
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects

Comments

@fcoveram
Copy link
Contributor

Description

While reviewing the components in storybook, I noticed a different version of the audio box small and the search bar on the staging site. I did not check all components but it might happen with other components too

Reproduction

  1. Open the small version of the audio box.
  2. Open the all content results of the staging site on a small device.
  3. Notice the difference by interacting with the component

Screenshots

Storybook Staging site

Resolution

  • 🙋 I would be interested in resolving this bug.
@fcoveram fcoveram added bug 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Jul 11, 2022
@krysal
Copy link
Member

krysal commented Jul 25, 2022

@panchovm To be specific on how to fix this, the audio box small component should look the same as on the desktop, right? Here is a GIF.
CleanShot 2022-07-25 at 17 00 17

@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 25, 2022
@fcoveram
Copy link
Contributor Author

fcoveram commented Aug 5, 2022

Neither as on storybook nor as on staging. Here you can see the Figma component, the smallest box versions. In hover and focus states, the element shows the CC license icons only.

@krysal krysal changed the title Different components in storybook and the staging site Different components in storybook and the staging site (audio box) Aug 30, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added 🧱 stack: frontend Related to the Nuxt frontend and removed bug labels Feb 22, 2023
@obulat
Copy link
Contributor

obulat commented Aug 10, 2023

The issue was solved, @fcoveram 🎉

@obulat obulat closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Openverse
  
Backlog
Development

No branches or pull requests

3 participants