Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add a disabled style to three components #1798

Closed
1 task
fcoveram opened this issue Sep 8, 2022 · 5 comments · Fixed by #1932
Closed
1 task

Add a disabled style to three components #1798

fcoveram opened this issue Sep 8, 2022 · 5 comments · Fixed by #1932
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents
Projects

Comments

@fcoveram
Copy link

fcoveram commented Sep 8, 2022

Problem

As noted in tickets WordPress/openverse#507 and #1790, some components need a "disabled" state to deny the use of some features, but the current Design Library does not have styles for the Content switcher and Filters components.

Description

To make this state visually consistent with other components, the Design Library was updated with a new variant in each Figma component mentioned. Here is the style for each one

Content switcher

Filters

Filters value

In all components, the style has dark-charcoal-10 as the background color, and dark-charcoal-40 for texts and icons.

Pointer update

As also noted and developed in #1790 it would be great to implement a style change in the pointer for all current and upcoming components, like the example below.

Implementation

  • 🙋 I would be interested in implementing this feature.
@fcoveram fcoveram added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature labels Sep 8, 2022
@openverse-bot openverse-bot added this to Backlog in Openverse Sep 8, 2022
@dhruvkb dhruvkb added good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents 🕹 aspect: interface Concerns end-users' experience with the software and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 9, 2022
@sourav25998
Copy link

Hi @dhruvkb . I would like to work on this issue. Please assign this to me.

@dhruvkb
Copy link
Member

dhruvkb commented Sep 10, 2022

Sure @sourav25998. Please go ahead.

@sourav25998
Copy link

Hi @dhruvkb . I'll be continuing with my issue that has been assigned to me in openverse-api at the moment. I shall come back to frontend once I am done with that issue. Thus, I am unassigning myself from this issue right now. Hope you understand

@vinzesiddharth29
Copy link

Hi @dhruvkb ,
It seems @sourav25998 is continuing with another issue, so I would like to work on this instead.
This issue is likely to be a good start of my journey towards contribution to FOSS projects.
Please assign this to me.

@sourav25998 sourav25998 removed their assignment Sep 12, 2022
@obulat obulat assigned obulat and unassigned vinzesiddharth29 Oct 18, 2022
@obulat
Copy link
Contributor

obulat commented Oct 18, 2022

I've self-assigned this issue because it's been a while, and it's marked as high priority. If you are interested in contributing, @vinzesiddharth29, please feel free to select another issue, and to reach out to the maintainers on the public Slack channel.

@openverse-bot openverse-bot moved this from Backlog to In progress in Openverse Oct 21, 2022
Openverse automation moved this from In progress to Done! Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging a pull request may close this issue.

5 participants