-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page for 'not supported' / 'coming soon' content types #507
Comments
I updated the Figma file where the mockup is with the following changes:
Here is the new mockup. I do not envision any other change as the original task (#1197) aims to update the "external source" term. |
In ticket WordPress/openverse-frontend#1798 I requested the component update to add the |
@panchovm looks great, thank you! One consideration: should these mockups use the row of external source buttons, or the new dropdown menu style for the external sources? |
A row of buttons. The dropdown menu was to prioritize Openverse results, but in this case, it is better to make the options more explicit. |
hey @zackkrida I want to contribute in this feature can I make pull request please provide your confirmation |
Hi @vj27111997 you are welcome to work on this! These changes exist in the |
hi @zackkrida i understand the changes you suggest,but i feel there is no issue v-else-if="!hasNoResults && !isSupported" block inside ,i think we do not need to change anything in this block now.it is just work fine. |
Hi @vineetjain27, I am not sure I am following your question. The section of the code I was referring to in my comment is this line https://github.com/WordPress/openverse-frontend/blob/c801914bcd05d64c0c58fac80ece43e2b05e1afd/src/components/VMetaSearch/VMetaSearchForm.vue#L17 To see this in the site, do the following:
|
please accept my merge request for this issue i am submit that request for while ago for this issue. |
@kridazack can you please tell approximately how much time my changes got accepted |
Hi @vj27111997 could you share a link to your pull request? I'm not seeing it anywhere. Also, it appears that |
Since no "coming soon" content type is displayed on the current site, does this problem still apply? |
@panchovm yes, we need to build the pages before we can show those links for new media types. Do you think these designs are still correct or do we need to make revisions? |
Hello @zackkrida , I would be interested in contributing to this issue. Could you please assign it to me? |
Those designs definitely need an update @zackkrida That update is mostly about text style and buttons, the layout grid can be the same. And since Core UI improvement project (#415) plans to update the button component, I would block this change until the improvement is done. The Figma button component is done, so for now you can contribute @Tomvth with creating the design file and picking the correct button style for this page. Otherwise, let's block this ticket until #415 is done |
* Refactor recreate_popularity_calculation DAGs out into a dag factory * Add dag parsing tests for all data refresh dags * Add docs for individual tasks * Use kwargs
Closing as not planned. |
Problem
We need to design and implement a page for the 'not supported' / 'coming soon' content types we would like to show in the content switcher. At the time of writing those are 3D models and video. Adding these pages will help us get a sense of interest in these content types. We can also show external sources for these content types in the meantime to help users.
Description
@panchovm started a design for these pages, but it needs to be updated and finished now that we've updated the copy and styling of the 'external sources' feature. Here's an example mockup he provided as a starting point:
Alternatives
Additional context
Implementation
The text was updated successfully, but these errors were encountered: