Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page for 'not supported' / 'coming soon' content types #507

Closed
1 task
zackkrida opened this issue Sep 6, 2022 · 16 comments
Closed
1 task

Page for 'not supported' / 'coming soon' content types #507

zackkrida opened this issue Sep 6, 2022 · 16 comments
Labels
🖼️ aspect: design Concerns related to design 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend ⛔ status: blocked Blocked & therefore, not ready for work
Projects

Comments

@zackkrida
Copy link
Member

Problem

We need to design and implement a page for the 'not supported' / 'coming soon' content types we would like to show in the content switcher. At the time of writing those are 3D models and video. Adding these pages will help us get a sense of interest in these content types. We can also show external sources for these content types in the meantime to help users.

Description

@panchovm started a design for these pages, but it needs to be updated and finished now that we've updated the copy and styling of the 'external sources' feature. Here's an example mockup he provided as a starting point:

181094969-ca8fc34c-4f00-4028-9271-40afa6f0cf58

Alternatives

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@zackkrida zackkrida added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature labels Sep 6, 2022
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 🖼️ aspect: design Concerns related to design and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature labels Sep 7, 2022
@fcoveram
Copy link
Contributor

fcoveram commented Sep 8, 2022

I updated the Figma file where the mockup is with the following changes:

  • Replaced "one of the additional sources" with "one of the external sources".
  • Updated the Filters button with a new disabled state.
  • Fixed the external icon size as the previous mockup had a component bug from the WordPress Design Library.

Here is the new mockup. I do not envision any other change as the original task (#1197) aims to update the "external source" term.

imagen

@fcoveram
Copy link
Contributor

fcoveram commented Sep 8, 2022

In ticket WordPress/openverse-frontend#1798 I requested the component update to add the disabled state.

@zackkrida
Copy link
Member Author

@panchovm looks great, thank you! One consideration: should these mockups use the row of external source buttons, or the new dropdown menu style for the external sources?

@fcoveram
Copy link
Contributor

fcoveram commented Sep 8, 2022

A row of buttons. The dropdown menu was to prioritize Openverse results, but in this case, it is better to make the options more explicit.

@vj27111997
Copy link

hey @zackkrida I want to contribute in this feature can I make pull request please provide your confirmation

@zackkrida
Copy link
Member Author

zackkrida commented Sep 9, 2022

Hi @vj27111997 you are welcome to work on this! These changes exist in the v-else-if="!hasNoResults && !isSupported" block inside of the https://github.com/WordPress/openverse-frontend/blob/c801914bcd05d64c0c58fac80ece43e2b05e1afd/src/components/VMetaSearch/VMetaSearchForm.vue component. Comment here and @ @WordPress/openverse-frontend with any questions.

@vineetjain27
Copy link

hi @zackkrida i understand the changes you suggest,but i feel there is no issue v-else-if="!hasNoResults && !isSupported" block inside ,i think we do not need to change anything in this block now.it is just work fine.

@zackkrida
Copy link
Member Author

Hi @vineetjain27, I am not sure I am following your question. The section of the code I was referring to in my comment is this line https://github.com/WordPress/openverse-frontend/blob/c801914bcd05d64c0c58fac80ece43e2b05e1afd/src/components/VMetaSearch/VMetaSearchForm.vue#L17

To see this in the site, do the following:

  1. Visit the preferences page of the staging site: https://search-staging.openverse.engineering/preferences
  2. Enable the external_sources feature
  3. Then, go to the search page: https://search-staging.openverse.engineering/search/?q=dogs
  4. You'll now see additional items in the content switcher:

CleanShot 2022-10-28 at 16 29 06

  1. Those "coming soon" items, video and 3d models, each need their own page using the template design shared in this comment: Page for 'not supported' / 'coming soon' content types #507

@vj27111997
Copy link

please accept my merge request for this issue i am submit that request for while ago for this issue.

@vj27111997
Copy link

@kridazack can you please tell approximately how much time my changes got accepted

@zackkrida
Copy link
Member Author

Hi @vj27111997 could you share a link to your pull request? I'm not seeing it anywhere.

Also, it appears that @kridazack is an account impersonating me; my username is @zackkrida.

@krysal krysal added the help wanted Open to participation from the community label Dec 20, 2022
@openverse-bot openverse-bot added this to Backlog in Openverse Feb 22, 2023
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@fcoveram
Copy link
Contributor

Since no "coming soon" content type is displayed on the current site, does this problem still apply?

@zackkrida
Copy link
Member Author

@panchovm yes, we need to build the pages before we can show those links for new media types. Do you think these designs are still correct or do we need to make revisions?

@Tomvth
Copy link
Contributor

Tomvth commented Mar 27, 2023

Hello @zackkrida , I would be interested in contributing to this issue. Could you please assign it to me?

@fcoveram
Copy link
Contributor

Those designs definitely need an update @zackkrida

That update is mostly about text style and buttons, the layout grid can be the same. And since Core UI improvement project (#415) plans to update the button component, I would block this change until the improvement is done.

The Figma button component is done, so for now you can contribute @Tomvth with creating the design file and picking the correct button style for this page. Otherwise, let's block this ticket until #415 is done

@obulat obulat removed the help wanted Open to participation from the community label Mar 28, 2023
@obulat obulat added the ⛔ status: blocked Blocked & therefore, not ready for work label Mar 28, 2023
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
* Refactor recreate_popularity_calculation DAGs out into a dag factory

* Add dag parsing tests for all data refresh dags

* Add docs for individual tasks

* Use kwargs
@obulat
Copy link
Contributor

obulat commented Aug 10, 2023

Closing as not planned.

@obulat obulat closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖼️ aspect: design Concerns related to design 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend ⛔ status: blocked Blocked & therefore, not ready for work
Projects
Archived in project
Openverse
  
Backlog
Development

No branches or pull requests

8 participants