Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add E2E tests to CI #554

Closed
1 task
sarayourfriend opened this issue Dec 23, 2021 · 1 comment
Closed
1 task

Add E2E tests to CI #554

sarayourfriend opened this issue Dec 23, 2021 · 1 comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@sarayourfriend
Copy link
Contributor

Problem

It is currently possible to catastrophically break the frontend in a PR that seems unrelated without knowing: #551

Description

We need to run the E2E test suite in CI to help prevent this.

Additional context

@dhruvkb recommended we look into this package to facilitate this: https://github.com/bahmutov/start-server-and-test

However, it's just occurred to me as I write this that we should run the E2E tests with the wp.org theme wrapper, to most closely replicate the production environment.

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Dec 23, 2021
@obulat
Copy link
Contributor

obulat commented Feb 15, 2022

Closing this issue as the #555 and adding more tests after it have added decent E2E check to our CI. We can, however, open a new issue for the new E2E tests that we should write.

@obulat obulat closed this as completed Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Development

No branches or pull requests

2 participants