Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Constrain Sketchfab Model height on single result view #888

Closed
zackkrida opened this issue Feb 16, 2022 · 3 comments · Fixed by #1325
Closed

Constrain Sketchfab Model height on single result view #888

zackkrida opened this issue Feb 16, 2022 · 3 comments · Fixed by #1325
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects

Comments

@zackkrida
Copy link
Member

Description

Sketchfab models are really tall on the new single result view.

https://search-staging.openverse.engineering/image/00a6a7a4-6605-4cba-bacf-a08b0da546b9

CleanShot 2022-02-16 at 14 55 41@2x

How could we constrain these so the entire model is visible at once?

CC @panchovm for design thought.

@zackkrida zackkrida added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Feb 16, 2022
@dhruvkb dhruvkb added this to Backlog in Openverse Feb 16, 2022
@fcoveram
Copy link

In the image details view (#682) I dropped the idea of restraining the container's width and height to place the main content in a visible viewport. That should solve the content size for all image cases.

@zackkrida
Copy link
Member Author

@panchovm 3D models are a bit different because they don't have an intrinsic size or aspect ratio, it's entirely up to us to decide how they should display. Sketchfab uses a roughly 9/5 aspect ratio on their single results:

https://sketchfab.com/3d-models/dog-run-cycle-496fcd675d214b5d82a6d37bf18d2374

@fcoveram
Copy link

Then a full width and height size view makes sense to me as long as we set a visible view to place the content. I still believe that 1000px width and 500px height is a worth exploring solution.

@krysal krysal removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 17, 2022
@sarayourfriend sarayourfriend self-assigned this Apr 25, 2022
@openverse-bot openverse-bot moved this from Backlog to In progress in Openverse Apr 25, 2022
Openverse automation moved this from In progress to Done! May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging a pull request may close this issue.

4 participants