Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove Vocabulary icon font #1097

Merged
merged 3 commits into from Mar 10, 2022
Merged

Remove Vocabulary icon font #1097

merged 3 commits into from Mar 10, 2022

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Mar 10, 2022

Description

This PR removes deprecated Vocabulary icon font.

The external link icon in two places was still using the icon font. I replaced them with VIcon with an svg icon. If the sizes need updating, that should be done in a separate PR:
Screen Shot 2022-03-10 at 2 14 25 PM
Screen Shot 2022-03-10 at 2 12 34 PM

Two components that are not used anymore were removed:

  • FilterTag
  • Dropdown

Testing Instructions

Check the meta search form and the sources page, the external link icons should be displayed correctly.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Mar 10, 2022
@obulat obulat requested a review from a team as a code owner March 10, 2022 11:31
@obulat obulat requested review from krysal and dhruvkb March 10, 2022 11:31
@dhruvkb dhruvkb added this to Needs review in Openverse PRs Mar 10, 2022
@dhruvkb dhruvkb added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work and removed 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Mar 10, 2022
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good to me!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect; lgtm!

Openverse PRs automation moved this from Needs review to Reviewer approved Mar 10, 2022
@obulat obulat merged commit 93b5741 into main Mar 10, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Mar 10, 2022
@obulat obulat deleted the remove_vocabulary_icons branch March 10, 2022 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants