Renamed Meta search to additional sources #1205

HILAYTRIVEDI · 2022-03-30T05:41:16Z

Fixes

Fixes #1197 by @zackkrida

Description

This PR will replace all the instances of the meta-search with additional sources available in the GitHub files.

Checklist

My pull request has a descriptive title (not a vague title like Update index.md).
My pull request targets the default branch of the repository (main) or a parent feature branch.
My commit messages follow [best practices][best_practices].
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible errors.

…l-sources

dhruvkb

I have some preliminary feedback before diving into the full review. This is good and covers most of the usages. There are a few issues, however:

package-lock.json should not be modified, please revert it to the same version as on main.
Since "Additional sources" is not the name of a feature as "Meta search" was, it's grammatically incorrect in some places. But those wordings will need to be changed anyway as a part of the Meta search redesign Update the meta search section with the new design #734 so it's not a blocking change.

This PR will conflict with both #1190 and #1203. I would highly recommend waiting for those to get merged before working on this.

dhruvkb · 2022-03-30T07:41:57Z

src/composables/use-pages.js

-      link: app.localePath('/meta-search'),
+      id: 'additional-sources',
+      name: 'header.additional-sources-nav-item',
+      link: app.localePath('/additional-sources'),


Since you've changed the link, you will need to rename src/pages/meta-search.vue to src/pages/additional-sources.vue. Nuxt uses file names to map to URLs.

Do we also want to map a redirect for the original URL?

dhruvkb · 2022-03-30T07:48:02Z

src/locales/en.json

    "intro": "{openverse} is built on top of a catalog that indexes CC-licensed and public domain content from selected sources. Learn more about our {link}.",
    "link": "sources",
    "license": "The internet is a big place! There are plenty of search portals and collections, hosting CC-licensed and public domain content, which we aren’t able to index or surface results from within the {openverse} interface. These are important sources of CC-licensed and public domain content, and we want to make sure that you are able to find the best openly licensed materials possible, regardless of where they are located.",
-    "content": "What content types can I search for using the Meta Search feature?",
-    "content-types": "Meta Search on {openverse} currently supports image, audio, and video search on external sites.",
+    "content": "What content types can I search for using the Additional Sources feature?",


Example of a grammatical error introduced because "Additional Sources" is not the proper-noun of a feature name but rather an adjective-qualified common-noun.

Suggested change

"content": "What content types can I search for using the Additional Sources feature?",

"content": "What content types are supported by additional sources?",

Similar changes are needed in other places in en.json.

Just a nit here, but this isn't technically a grammatical error, and in fact could maybe even be clearer than what you suggested in context. At least in this case the phrase 'Additional Sources feature' groups it as a single block. In other strings you're right that it reads awkwardly to just replace "Meta Search" directly with "Additional Sources", but only because it's not qualifying "feature".

In general I think the wording is probably bad here because we're treating "Additional Sources" (even if lower cased) as a feature and also the name of a collection of external resources. I think it could be a good idea to revisit this group of strings altogether instead of doing a 1-to-1 term replacement. For example, this particular string is really confusing to read as it could be asking either "what content types do the websites listed in the additional sources feature support" or it could read "what content types does Openverse integrate 'additional sources' into"... both of which expose what I think is still a really unclear name we've chosen in "additional sources" (it's maybe even more unclear than the very obscure "meta search" if only because "meta search" is almost semantically meaningless the way we used it but "additional sources" is rife with ways of misunderstanding/misinterpreting).

HILAYTRIVEDI · 2022-03-30T08:09:27Z

Hi @dhruvkb, Thank you for the info. I will wait till the PRs will merge

HILAYTRIVEDI

I did the required changes But waiting for the PRs to be merged. once they are being pushed I will push my code too.

dhruvkb · 2022-03-30T13:13:08Z

Thanks @HILAYTRIVEDI! Feel free to pick up another issue in the meantime.

…l-sources

sarayourfriend · 2022-04-04T06:19:46Z

@HILAYTRIVEDI please note that we use pnpm, not npm to install dependencies. While things may work with npm install you won't be running with the exact versions of packages that we've locked to and tested with. Please do follow the instructions in the README's "Local Development" section to correctly set up your local environment (and avoid introducing things like package-lock.json for example).

Thanks for the contribution!

krysal

@HILAYTRIVEDI are you still interested in completing this PR? Try resolving conflicts with main in that case, we can help if you have questions, or let us know if you can't continue working on this. Thanks!

HILAYTRIVEDI · 2022-06-14T14:07:14Z

Hi @krysal , @dhruvkb asked me to hold this ticket untill 1190 and 1203 will merge. I come to find that they are merge now. So yes I will start to work on this now.

…l-sources # Conflicts: # src/components/VMetaSearch/VMetaSearchForm.vue # src/locales/po-files/openverse.pot # src/pages/meta-search.vue # src/utils/get-legacy-source-url.js

obulat

Thank you for your work on this issue, @HILAYTRIVEDI !
I've merged main into your PR, and fixed the 'additional sources' page by renaming it to additional-sources.vue. It's still necessary to proofread the text of that page.

zackkrida · 2022-08-01T16:27:34Z

Hi @HILAYTRIVEDI we have the final language this PR needs. You can see it here: #1197 (comment)

Would you like to continue working on this or have someone else take over?

zackkrida · 2022-08-15T13:24:10Z

Closing in favor of #1665 due to some inactivity and needed changes.

Renamed Meta search to additional sources

6542561

HILAYTRIVEDI requested a review from a team as a code owner March 30, 2022 05:41

HILAYTRIVEDI requested review from krysal and dhruvkb March 30, 2022 05:41

dhruvkb added this to Needs review in Openverse PRs Mar 30, 2022

dhruvkb added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Mar 30, 2022

HILAYTRIVEDI and others added 2 commits March 30, 2022 11:34

Updated POT File added

233cdc5

Merge branch 'main' into update/1197-renamed-meta-search-to-additiona…

c72ea33

…l-sources

dhruvkb suggested changes Mar 30, 2022

View reviewed changes

dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 📄 aspect: text Concerns the textual material in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Mar 30, 2022

HILAYTRIVEDI commented Mar 30, 2022

View reviewed changes

Merge branch 'main' into update/1197-renamed-meta-search-to-additiona…

8a37408

…l-sources

krysal reviewed Jun 14, 2022

View reviewed changes

obulat added 5 commits June 16, 2022 14:19

Merge branch 'main' into update/1197-renamed-meta-search-to-additiona…

58a6558

…l-sources # Conflicts: # src/components/VMetaSearch/VMetaSearchForm.vue # src/locales/po-files/openverse.pot # src/pages/meta-search.vue # src/utils/get-legacy-source-url.js

Update pot file

e136f9c

Revert unnecessary changes

5d72ce2

Update locale files

b2ad1c2

Rename the page

cea364b

obulat reviewed Jun 16, 2022

View reviewed changes

Update pot file

1087d02

zackkrida closed this Aug 15, 2022

Openverse PRs automation moved this from Needs review to Closed Aug 15, 2022

krysal mentioned this pull request Aug 15, 2022

Add External sources popover instead of the Meta search form #1665

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renamed Meta search to additional sources #1205

Renamed Meta search to additional sources #1205

HILAYTRIVEDI commented Mar 30, 2022 •

edited by dhruvkb

dhruvkb left a comment

dhruvkb Mar 30, 2022

sarayourfriend Apr 4, 2022 •

edited

dhruvkb Mar 30, 2022 •

edited

sarayourfriend Jun 16, 2022

HILAYTRIVEDI commented Mar 30, 2022

HILAYTRIVEDI left a comment

dhruvkb commented Mar 30, 2022

sarayourfriend commented Apr 4, 2022

krysal left a comment

HILAYTRIVEDI commented Jun 14, 2022

obulat left a comment

zackkrida commented Aug 1, 2022

zackkrida commented Aug 15, 2022

	"content": "What content types can I search for using the Additional Sources feature?",
	"content": "What content types are supported by additional sources?",

Renamed Meta search to additional sources #1205

Renamed Meta search to additional sources #1205

Conversation

HILAYTRIVEDI commented Mar 30, 2022 • edited by dhruvkb

Fixes

Description

Checklist

dhruvkb left a comment

Choose a reason for hiding this comment

dhruvkb Mar 30, 2022

Choose a reason for hiding this comment

sarayourfriend Apr 4, 2022 • edited

Choose a reason for hiding this comment

dhruvkb Mar 30, 2022 • edited

Choose a reason for hiding this comment

sarayourfriend Jun 16, 2022

Choose a reason for hiding this comment

HILAYTRIVEDI commented Mar 30, 2022

HILAYTRIVEDI left a comment

Choose a reason for hiding this comment

dhruvkb commented Mar 30, 2022

sarayourfriend commented Apr 4, 2022

krysal left a comment

Choose a reason for hiding this comment

HILAYTRIVEDI commented Jun 14, 2022

obulat left a comment

Choose a reason for hiding this comment

zackkrida commented Aug 1, 2022

zackkrida commented Aug 15, 2022

HILAYTRIVEDI commented Mar 30, 2022 •

edited by dhruvkb

sarayourfriend Apr 4, 2022 •

edited

dhruvkb Mar 30, 2022 •

edited