This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Update Node.js to v16.15.0 #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/node-16.x
branch
from
92cf266
to
60ca5af
Compare
dhruvkb
approved these changes
May 2, 2022
|
I don't understand the artifact update problem. @dhruvkb did you take a look at that? I don't know why it's trying to use |
|
Not sure about that Renovate message, but the Node version change posed no issue locally. Everything was working like before. I'll do some checking, let's hold off on merging this for a while. |
renovate
bot
force-pushed
the
renovate/node-16.x
branch
from
60ca5af
to
2a82cb7
Compare
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1360 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
renovate
bot
force-pushed
the
renovate/node-16.x
branch
4 times, most recently
from
98d99a3
to
d25395e
Compare
|
Ah! I understand the problem here @dhruvkb... it's the same pnpm version pinning issue! 🤦 I'll try and find a solution for this. Maybe renovate lets you pin the version. |
|
Looks like it might be possible with https://docs.renovatebot.com/configuration-options/#constraints |
renovate
bot
force-pushed
the
renovate/node-16.x
branch
from
d25395e
to
35310d4
Compare
|
Merging this is dependent on #1420 |
renovate
bot
force-pushed
the
renovate/node-16.x
branch
from
35310d4
to
812cd2a
Compare
renovate
bot
force-pushed
the
renovate/node-16.x
branch
from
812cd2a
to
bd241b0
Compare
pnpm-lock.yaml
Outdated
| typescript: 4.6.2 | ||
| fork-ts-checker-webpack-plugin: 6.5.0_74f2hvla7n4b757hwnerd4quka | ||
| ts-loader: 8.3.0_e7hrjdrs22zc4syxbltzlwluhe | ||
| typescript: 4.2.4 |
There was a problem hiding this comment.
😱
Looks like we still need that TypeScript resolution after all 😕
Edit: we do still have it. I had to checkout this branch and run pnpm install after removing the lock file to get it to resolve to the right TS version 😕
sarayourfriend
approved these changes
May 13, 2022
|
Size Change: -3 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
16.13.0->16.15.0Configuration
📅 Schedule: "before 3am on the first day of the month" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.