Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Stop Global Audio player from playing loose audio #1750

Merged
merged 4 commits into from Aug 31, 2022

Conversation

krysal
Copy link
Member

@krysal krysal commented Aug 26, 2022

Fixes

Fixes #1537 by @obulat

Description

This PR limits the reproduction of the global audio to the 'search-audio' and its own 'audio-id' (Audio Details) routes on desktop viewports.

I added a base test for the happy path of the global audio but I don't know yet how to create the test for the actual bug, suggestions are welcome.

Testing Instructions

Follow the steps of the linked issue and observe the audio stops.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal requested a review from a team as a code owner August 26, 2022 21:24
@krysal krysal requested review from obulat and dhruvkb August 26, 2022 21:24
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Aug 26, 2022
@github-actions
Copy link

github-actions bot commented Aug 26, 2022

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/1750
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1750/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon labels Aug 26, 2022
@github-actions
Copy link

github-actions bot commented Aug 26, 2022

Size Change: -8.1 kB (-1%)

Total Size: 768 kB

Filename Size Change
./.nuxt/dist/client/234.js 1.85 kB +1.58 kB (+581%) 🆘
./.nuxt/dist/client/234.modern.js 0 B -277 B (removed) 🏆
./.nuxt/dist/client/235.js 0 B -1.85 kB (removed) 🏆
./.nuxt/dist/client/app.js 110 kB -563 B (-1%)
./.nuxt/dist/client/app.modern.js 102 kB -81 B (0%)
./.nuxt/dist/client/commons/app.js 87.8 kB +3.72 kB (+4%)
./.nuxt/dist/client/commons/app.modern.js 76.7 kB +3.82 kB (+5%) 🔍
./.nuxt/dist/client/components/loading-icon.js 746 B -20 B (-3%)
./.nuxt/dist/client/components/loading-icon.modern.js 751 B -17 B (-2%)
./.nuxt/dist/client/components/v-audio-details.js 1.66 kB +13 B (+1%)
./.nuxt/dist/client/components/v-audio-track.js 4.55 kB +64 B (+1%)
./.nuxt/dist/client/components/v-audio-track.modern.js 4.51 kB +70 B (+2%)
./.nuxt/dist/client/components/v-content-report-button.js 763 B -13 B (-2%)
./.nuxt/dist/client/components/v-content-report-form.js 3.78 kB +17 B (0%)
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.59 kB +18 B (+1%)
./.nuxt/dist/client/components/v-content-report-popover.js 4.45 kB +21 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.26 kB +33 B (+1%)
./.nuxt/dist/client/components/v-copy-license.js 2.94 kB -16 B (-1%)
./.nuxt/dist/client/components/v-copy-license.modern.js 2.91 kB -15 B (-1%)
./.nuxt/dist/client/components/v-error-section.js 372 B -15 B (-4%)
./.nuxt/dist/client/components/v-error-section.modern.js 375 B -16 B (-4%)
./.nuxt/dist/client/components/v-full-layout.js 1.55 kB +78 B (+5%) 🔍
./.nuxt/dist/client/components/v-full-layout.modern.js 1.55 kB +80 B (+5%) 🔍
./.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB -12 B (-1%)
./.nuxt/dist/client/components/v-image-grid.js 2.57 kB -12 B (0%)
./.nuxt/dist/client/components/v-image-grid.modern.js 2.46 kB -11 B (0%)
./.nuxt/dist/client/components/v-media-reuse/pages/image/_id.js 2.94 kB -14 B (0%)
./.nuxt/dist/client/components/v-media-reuse/pages/image/_id.modern.js 2.91 kB -16 B (-1%)
./.nuxt/dist/client/components/v-radio.js 1.51 kB -12 B (-1%)
./.nuxt/dist/client/components/v-radio.modern.js 1.47 kB -11 B (-1%)
./.nuxt/dist/client/components/v-related-audio.js 1.23 kB -19 B (-2%)
./.nuxt/dist/client/components/v-related-audio.modern.js 1.24 kB -16 B (-1%)
./.nuxt/dist/client/components/v-related-images.modern.js 3.02 kB -10 B (0%)
./.nuxt/dist/client/components/v-server-timeout.js 298 B -16 B (-5%)
./.nuxt/dist/client/components/v-server-timeout.modern.js 303 B -17 B (-5%)
./.nuxt/dist/client/components/v-sidebar-content.js 0 B -442 B (removed) 🏆
./.nuxt/dist/client/components/v-sidebar-content.modern.js 0 B -443 B (removed) 🏆
./.nuxt/dist/client/components/v-sources-table.js 14.3 kB +13 B (0%)
./.nuxt/dist/client/pages/audio/_id.js 6.42 kB +12 B (0%)
./.nuxt/dist/client/pages/image/_id.js 7.05 kB +81 B (+1%)
./.nuxt/dist/client/pages/image/_id.modern.js 6.83 kB +77 B (+1%)
./.nuxt/dist/client/pages/index.modern.js 4.97 kB +11 B (0%)
./.nuxt/dist/client/pages/meta-search.js 1.67 kB -13 B (-1%)
./.nuxt/dist/client/pages/meta-search.modern.js 1.67 kB -11 B (-1%)
./.nuxt/dist/client/pages/search/audio.js 2.86 kB -10 B (0%)
./.nuxt/dist/client/pages/search/image.js 2.96 kB -13 B (0%)
./.nuxt/dist/client/pages/search/image.modern.js 2.83 kB -13 B (0%)
./.nuxt/dist/client/pages/search/model-3d.js 243 B -17 B (-7%)
./.nuxt/dist/client/pages/search/model-3d.modern.js 246 B -17 B (-6%)
./.nuxt/dist/client/pages/search/video.js 239 B -18 B (-7%)
./.nuxt/dist/client/pages/search/video.modern.js 243 B -19 B (-7%)
./.nuxt/dist/client/runtime.js 2.7 kB -15 B (-1%)
./.nuxt/dist/client/runtime.modern.js 2.7 kB -14 B (-1%)
./.nuxt/dist/client/vendors/app.js 47.8 kB -6.91 kB (-13%) 👏
./.nuxt/dist/client/vendors/app.modern.js 47.1 kB -7.07 kB (-13%) 👏
./.nuxt/dist/client/233.js 273 B +273 B (new file) 🆕
./.nuxt/dist/client/233.modern.js 277 B +277 B (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./.nuxt/dist/client/components/table-sort-icon.js 508 B -7 B (-1%)
./.nuxt/dist/client/components/table-sort-icon.modern.js 512 B -8 B (-2%)
./.nuxt/dist/client/components/v-all-results-grid.js 4.13 kB +2 B (0%)
./.nuxt/dist/client/components/v-all-results-grid.modern.js 4.01 kB +4 B (0%)
./.nuxt/dist/client/components/v-audio-cell.js 344 B -4 B (-1%)
./.nuxt/dist/client/components/v-audio-cell.modern.js 349 B -4 B (-1%)
./.nuxt/dist/client/components/v-audio-details.modern.js 1.65 kB -1 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB -1 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB -1 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.js 570 B -5 B (-1%)
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 575 B -6 B (-1%)
./.nuxt/dist/client/components/v-bone.js 685 B -9 B (-1%)
./.nuxt/dist/client/components/v-bone.modern.js 690 B -9 B (-1%)
./.nuxt/dist/client/components/v-box-layout.js 1.19 kB -9 B (-1%)
./.nuxt/dist/client/components/v-box-layout.modern.js 1.19 kB -6 B (-1%)
./.nuxt/dist/client/components/v-content-link.js 1.06 kB +3 B (0%)
./.nuxt/dist/client/components/v-content-link.modern.js 1.04 kB -2 B (0%)
./.nuxt/dist/client/components/v-content-page.js 467 B -6 B (-1%)
./.nuxt/dist/client/components/v-content-page.modern.js 471 B -6 B (-1%)
./.nuxt/dist/client/components/v-content-report-button.modern.js 773 B -7 B (-1%)
./.nuxt/dist/client/components/v-copy-button.js 3.97 kB -3 B (0%)
./.nuxt/dist/client/components/v-copy-button.modern.js 3.98 kB -2 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js 9.4 kB -7 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js 9.38 kB -1 B (0%)
./.nuxt/dist/client/components/v-dmca-notice.js 743 B -9 B (-1%)
./.nuxt/dist/client/components/v-dmca-notice.modern.js 753 B -5 B (-1%)
./.nuxt/dist/client/components/v-error-image.js 1.69 kB +2 B (0%)
./.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB +1 B (0%)
./.nuxt/dist/client/components/v-grid-skeleton.js 1.61 kB -9 B (-1%)
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB -5 B (0%)
./.nuxt/dist/client/components/v-image-cell-square.js 1.01 kB -7 B (-1%)
./.nuxt/dist/client/components/v-image-cell-square.modern.js 1.02 kB -4 B (0%)
./.nuxt/dist/client/components/v-image-cell.js 1.43 kB -4 B (0%)
./.nuxt/dist/client/components/v-image-cell.modern.js 1.42 kB -1 B (0%)
./.nuxt/dist/client/components/v-image-details.js 1.44 kB -5 B (0%)
./.nuxt/dist/client/components/v-license-tab-panel.js 923 B -8 B (-1%)
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 918 B -7 B (-1%)
./.nuxt/dist/client/components/v-load-more.js 815 B -5 B (-1%)
./.nuxt/dist/client/components/v-load-more.modern.js 714 B -3 B (0%)
./.nuxt/dist/client/components/v-media-license.js 801 B -5 B (-1%)
./.nuxt/dist/client/components/v-media-license.modern.js 809 B -5 B (-1%)
./.nuxt/dist/client/components/v-media-reuse.js 1.03 kB +6 B (+1%)
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.03 kB +2 B (0%)
./.nuxt/dist/client/components/v-media-tag.js 429 B -3 B (-1%)
./.nuxt/dist/client/components/v-media-tag.modern.js 433 B -3 B (-1%)
./.nuxt/dist/client/components/v-meta-search-form.js 2.7 kB +2 B (0%)
./.nuxt/dist/client/components/v-meta-search-form.modern.js 2.66 kB -4 B (0%)
./.nuxt/dist/client/components/v-meta-source-list.js 2.06 kB -1 B (0%)
./.nuxt/dist/client/components/v-meta-source-list.modern.js 2.02 kB -7 B (0%)
./.nuxt/dist/client/components/v-modal.js 875 B -2 B (0%)
./.nuxt/dist/client/components/v-modal.modern.js 876 B -5 B (-1%)
./.nuxt/dist/client/components/v-no-results.js 2.27 kB +1 B (0%)
./.nuxt/dist/client/components/v-no-results.modern.js 2.23 kB -4 B (0%)
./.nuxt/dist/client/components/v-related-images.js 3.14 kB -8 B (0%)
./.nuxt/dist/client/components/v-report-desc-form.js 965 B +5 B (+1%)
./.nuxt/dist/client/components/v-report-desc-form.modern.js 964 B +2 B (0%)
./.nuxt/dist/client/components/v-row-layout.js 1.72 kB 0 B
./.nuxt/dist/client/components/v-row-layout.modern.js 1.73 kB -1 B (0%)
./.nuxt/dist/client/components/v-scroll-button.js 804 B -3 B (0%)
./.nuxt/dist/client/components/v-scroll-button.modern.js 809 B -4 B (0%)
./.nuxt/dist/client/components/v-search-grid.js 5.06 kB +9 B (0%)
./.nuxt/dist/client/components/v-search-grid.modern.js 4.99 kB +3 B (0%)
./.nuxt/dist/client/components/v-search-results-title.js 673 B -2 B (0%)
./.nuxt/dist/client/components/v-search-results-title.modern.js 666 B -4 B (-1%)
./.nuxt/dist/client/components/v-search-type-radio.js 831 B -2 B (0%)
./.nuxt/dist/client/components/v-search-type-radio.modern.js 820 B -4 B (0%)
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 991 B -5 B (-1%)
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 892 B -1 B (0%)
./.nuxt/dist/client/components/v-skip-to-content-container.js 888 B -3 B (0%)
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 891 B -5 B (-1%)
./.nuxt/dist/client/components/v-snackbar.js 977 B -4 B (0%)
./.nuxt/dist/client/components/v-snackbar.modern.js 983 B -3 B (0%)
./.nuxt/dist/client/components/v-sources-table.modern.js 14.3 kB +5 B (0%)
./.nuxt/dist/client/components/v-tab-panel.js 689 B +1 B (0%)
./.nuxt/dist/client/components/v-tab-panel.modern.js 683 B 0 B
./.nuxt/dist/client/components/v-tab.js 1.73 kB -2 B (0%)
./.nuxt/dist/client/components/v-tab.modern.js 1.71 kB -3 B (0%)
./.nuxt/dist/client/components/v-tabs.js 779 B -7 B (-1%)
./.nuxt/dist/client/components/v-tabs.modern.js 766 B -4 B (-1%)
./.nuxt/dist/client/components/v-warning-suppressor.js 298 B -3 B (-1%)
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 302 B -3 B (-1%)
./.nuxt/dist/client/pages/about.js 1.05 kB -8 B (-1%)
./.nuxt/dist/client/pages/about.modern.js 1.06 kB -7 B (-1%)
./.nuxt/dist/client/pages/audio/_id.modern.js 6.26 kB 0 B
./.nuxt/dist/client/pages/feedback.js 3.23 kB -4 B (0%)
./.nuxt/dist/client/pages/feedback.modern.js 3.2 kB -9 B (0%)
./.nuxt/dist/client/pages/index.js 5.09 kB +7 B (0%)
./.nuxt/dist/client/pages/preferences.js 1.28 kB +6 B (0%)
./.nuxt/dist/client/pages/preferences.modern.js 1.27 kB +2 B (0%)
./.nuxt/dist/client/pages/search-help.js 1.54 kB +4 B (0%)
./.nuxt/dist/client/pages/search-help.modern.js 1.55 kB -2 B (0%)
./.nuxt/dist/client/pages/search.js 2.72 kB -1 B (0%)
./.nuxt/dist/client/pages/search.modern.js 2.56 kB -3 B (0%)
./.nuxt/dist/client/pages/search/audio.modern.js 2.75 kB -9 B (0%)
./.nuxt/dist/client/pages/search/index.js 816 B -5 B (-1%)
./.nuxt/dist/client/pages/search/index.modern.js 731 B -4 B (-1%)
./.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B 0 B
./.nuxt/dist/client/pages/sources.js 1.44 kB -9 B (-1%)
./.nuxt/dist/client/pages/sources.modern.js 1.45 kB -5 B (0%)

compressed-size-action

@krysal krysal force-pushed the fix/global-audio-player-on-desktop branch from 0e388b9 to 84268f8 Compare August 26, 2022 21:33
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this fixes this really annoying problem!
One step closer to getting audio out of beta 🎉

test/playwright/e2e/global-audio.spec.ts Show resolved Hide resolved
@obulat obulat added this to the Remove Audio's 'Beta' status milestone Aug 30, 2022
@krysal krysal requested a review from zackkrida August 30, 2022 14:57
@krysal krysal removed this from the Remove Audio's 'Beta' status milestone Aug 30, 2022
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Openverse PRs automation moved this from Needs review to Reviewer approved Aug 30, 2022
Co-authored-by: Zack Krida <zackkrida@pm.me>
@krysal krysal merged commit 4715594 into main Aug 31, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Aug 31, 2022
@krysal krysal deleted the fix/global-audio-player-on-desktop branch August 31, 2022 14:47
github-actions bot pushed a commit that referenced this pull request Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

The audio from search results keeps playing on the single result page even without the global player
4 participants