Stop Global Audio player from playing loose audio #1750
Conversation
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1750 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
Size Change: -8.1 kB (-1%) Total Size: 768 kB
ℹ️ View Unchanged
|
0e388b9
to
84268f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this fixes this really annoying problem!
One step closer to getting audio out of beta 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Co-authored-by: Zack Krida <zackkrida@pm.me>
Fixes
Fixes #1537 by @obulat
Description
This PR limits the reproduction of the global audio to the 'search-audio' and its own 'audio-id' (Audio Details) routes on desktop viewports.
I added a base test for the happy path of the global audio but I don't know yet how to create the test for the actual bug, suggestions are welcome.
Testing Instructions
Follow the steps of the linked issue and observe the audio stops.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin