Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update the Filters button #1861

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Update the Filters button #1861

merged 1 commit into from
Oct 4, 2022

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 24, 2022 •
edited

Fixes

Fixes #1866 by @obulat

Description

This PR uses the updated styles for action-menu buttons from #1863. The VFilterButton component is simplified because there are only 2 variants now, and it's only used above the lg breakpoint.

Testing Instructions

Check the Storybook:
https://wordpress.github.io/openverse-frontend/_preview/1861/?path=/docs/components-vheader-vfilterbutton--default-story
The old filter button (with the new_header flag turned on) should stay the same, and the new filter button should be updated.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added this to the Create new header and footer milestone Sep 24, 2022
@github-actions
Copy link

github-actions bot commented Sep 24, 2022 •
edited

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/1861
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1861/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added this to In progress in Openverse PRs Sep 24, 2022
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Sep 24, 2022
@github-actions
Copy link

github-actions bot commented Sep 24, 2022 •
edited

Size Change: -2.54 kB (0%)

Total Size: 810 kB

Filename Size Change
./.nuxt/dist/client/235.js 0 B -272 B (removed) 🏆
./.nuxt/dist/client/235.modern.js 0 B -277 B (removed) 🏆
./.nuxt/dist/client/236.js 0 B -1.85 kB (removed) 🏆
./.nuxt/dist/client/app.js 126 kB -1.23 kB (-1%)
./.nuxt/dist/client/app.modern.js 118 kB -1.26 kB (-1%)
./.nuxt/dist/client/components/v-sources-table.js 15 kB +31 B (0%)
./.nuxt/dist/client/components/v-sources-table.modern.js 15.1 kB +31 B (0%)
./.nuxt/dist/client/runtime.js 2.66 kB -58 B (-2%)
./.nuxt/dist/client/runtime.modern.js 2.67 kB -57 B (-2%)
./.nuxt/dist/client/224.js 272 B +272 B (new file) 🆕
./.nuxt/dist/client/224.modern.js 277 B +277 B (new file) 🆕
./.nuxt/dist/client/225.js 1.85 kB +1.85 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./.nuxt/dist/client/commons/app.js 88.1 kB 0 B
./.nuxt/dist/client/commons/app.modern.js 77 kB 0 B
./.nuxt/dist/client/components/loading-icon.js 747 B 0 B
./.nuxt/dist/client/components/loading-icon.modern.js 751 B 0 B
./.nuxt/dist/client/components/table-sort-icon.js 508 B 0 B
./.nuxt/dist/client/components/table-sort-icon.modern.js 512 B 0 B
./.nuxt/dist/client/components/v-all-results-grid.js 2.78 kB 0 B
./.nuxt/dist/client/components/v-all-results-grid.modern.js 2.75 kB 0 B
./.nuxt/dist/client/components/v-all-results-grid/pages/search/audio/pages/search/index.js 3.02 kB 0 B
./.nuxt/dist/client/components/v-all-results-grid/pages/search/audio/pages/search/index.modern.js 2.91 kB 0 B
./.nuxt/dist/client/components/v-audio-cell.js 357 B 0 B
./.nuxt/dist/client/components/v-audio-cell.modern.js 360 B 0 B
./.nuxt/dist/client/components/v-audio-details.js 1.81 kB 0 B
./.nuxt/dist/client/components/v-audio-details.modern.js 1.79 kB 0 B
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB 0 B
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.01 kB 0 B
./.nuxt/dist/client/components/v-audio-track.js 5.11 kB 0 B
./.nuxt/dist/client/components/v-audio-track.modern.js 5.05 kB 0 B
./.nuxt/dist/client/components/v-back-to-search-results-link.js 569 B 0 B
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 573 B 0 B
./.nuxt/dist/client/components/v-bone.js 685 B 0 B
./.nuxt/dist/client/components/v-bone.modern.js 689 B 0 B
./.nuxt/dist/client/components/v-box-layout.js 1.2 kB 0 B
./.nuxt/dist/client/components/v-box-layout.modern.js 1.2 kB 0 B
./.nuxt/dist/client/components/v-content-link.js 1.13 kB 0 B
./.nuxt/dist/client/components/v-content-link.modern.js 1.11 kB 0 B
./.nuxt/dist/client/components/v-content-page.js 466 B 0 B
./.nuxt/dist/client/components/v-content-page.modern.js 471 B 0 B
./.nuxt/dist/client/components/v-content-report-button.js 779 B 0 B
./.nuxt/dist/client/components/v-content-report-button.modern.js 783 B 0 B
./.nuxt/dist/client/components/v-content-report-form.js 3.75 kB 0 B
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.56 kB 0 B
./.nuxt/dist/client/components/v-content-report-popover.js 4.43 kB 0 B
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.24 kB 0 B
./.nuxt/dist/client/components/v-copy-button.js 3.98 kB 0 B
./.nuxt/dist/client/components/v-copy-button.modern.js 3.99 kB 0 B
./.nuxt/dist/client/components/v-copy-license.js 2.95 kB 0 B
./.nuxt/dist/client/components/v-copy-license.modern.js 2.93 kB 0 B
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js 9.69 kB 0 B
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js 9.66 kB 0 B
./.nuxt/dist/client/components/v-dmca-notice.js 748 B 0 B
./.nuxt/dist/client/components/v-dmca-notice.modern.js 753 B 0 B
./.nuxt/dist/client/components/v-error-image.js 1.69 kB 0 B
./.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB 0 B
./.nuxt/dist/client/components/v-error-section.js 373 B 0 B
./.nuxt/dist/client/components/v-error-section.modern.js 377 B 0 B
./.nuxt/dist/client/components/v-full-layout.js 1.48 kB 0 B
./.nuxt/dist/client/components/v-full-layout.modern.js 1.48 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.js 1.6 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.6 kB 0 B
./.nuxt/dist/client/components/v-image-cell-square.js 1.01 kB 0 B
./.nuxt/dist/client/components/v-image-cell-square.modern.js 1.02 kB 0 B
./.nuxt/dist/client/components/v-image-cell.js 1.43 kB 0 B
./.nuxt/dist/client/components/v-image-cell.modern.js 1.42 kB 0 B
./.nuxt/dist/client/components/v-image-details.js 1.44 kB 0 B
./.nuxt/dist/client/components/v-image-details.modern.js 1.44 kB 0 B
./.nuxt/dist/client/components/v-image-grid.js 2.53 kB 0 B
./.nuxt/dist/client/components/v-image-grid.modern.js 2.42 kB 0 B
./.nuxt/dist/client/components/v-license-tab-panel.js 922 B 0 B
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 920 B 0 B
./.nuxt/dist/client/components/v-load-more.js 787 B 0 B
./.nuxt/dist/client/components/v-load-more.modern.js 684 B 0 B
./.nuxt/dist/client/components/v-media-license.js 800 B 0 B
./.nuxt/dist/client/components/v-media-license.modern.js 810 B 0 B
./.nuxt/dist/client/components/v-media-reuse.js 1.08 kB 0 B
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.08 kB 0 B
./.nuxt/dist/client/components/v-media-reuse/pages/image/_id.js 2.95 kB 0 B
./.nuxt/dist/client/components/v-media-reuse/pages/image/_id.modern.js 2.93 kB 0 B
./.nuxt/dist/client/components/v-media-tag.js 430 B 0 B
./.nuxt/dist/client/components/v-media-tag.modern.js 434 B 0 B
./.nuxt/dist/client/components/v-meta-search-form.js 3.1 kB 0 B
./.nuxt/dist/client/components/v-meta-search-form.modern.js 3.08 kB 0 B
./.nuxt/dist/client/components/v-meta-source-list.js 2.57 kB 0 B
./.nuxt/dist/client/components/v-meta-source-list.modern.js 2.54 kB 0 B
./.nuxt/dist/client/components/v-no-results.js 2.77 kB 0 B
./.nuxt/dist/client/components/v-no-results.modern.js 2.74 kB 0 B
./.nuxt/dist/client/components/v-radio.js 1.51 kB 0 B
./.nuxt/dist/client/components/v-radio.modern.js 1.47 kB 0 B
./.nuxt/dist/client/components/v-related-audio.js 1.23 kB 0 B
./.nuxt/dist/client/components/v-related-audio.modern.js 1.23 kB 0 B
./.nuxt/dist/client/components/v-related-images.js 3.09 kB 0 B
./.nuxt/dist/client/components/v-related-images.modern.js 2.98 kB 0 B
./.nuxt/dist/client/components/v-report-desc-form.js 965 B 0 B
./.nuxt/dist/client/components/v-report-desc-form.modern.js 965 B 0 B
./.nuxt/dist/client/components/v-row-layout.js 1.68 kB 0 B
./.nuxt/dist/client/components/v-row-layout.modern.js 1.69 kB 0 B
./.nuxt/dist/client/components/v-scroll-button.js 813 B 0 B
./.nuxt/dist/client/components/v-scroll-button.modern.js 818 B 0 B
./.nuxt/dist/client/components/v-search-grid.js 5.45 kB 0 B
./.nuxt/dist/client/components/v-search-grid.modern.js 5.4 kB 0 B
./.nuxt/dist/client/components/v-search-results-title.js 657 B 0 B
./.nuxt/dist/client/components/v-search-results-title.modern.js 654 B 0 B
./.nuxt/dist/client/components/v-search-type-radio.js 793 B 0 B
./.nuxt/dist/client/components/v-search-type-radio.modern.js 770 B 0 B
./.nuxt/dist/client/components/v-server-timeout.js 298 B 0 B
./.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 995 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 894 B 0 B
./.nuxt/dist/client/components/v-skip-to-content-container.js 887 B 0 B
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 893 B 0 B
./.nuxt/dist/client/components/v-snackbar.js 1.18 kB 0 B
./.nuxt/dist/client/components/v-snackbar.modern.js 1.19 kB 0 B
./.nuxt/dist/client/components/v-tab-panel.js 688 B 0 B
./.nuxt/dist/client/components/v-tab-panel.modern.js 684 B 0 B
./.nuxt/dist/client/components/v-tab.js 1.73 kB 0 B
./.nuxt/dist/client/components/v-tab.modern.js 1.72 kB 0 B
./.nuxt/dist/client/components/v-tabs.js 779 B 0 B
./.nuxt/dist/client/components/v-tabs.modern.js 765 B 0 B
./.nuxt/dist/client/components/v-warning-suppressor.js 299 B 0 B
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 303 B 0 B
./.nuxt/dist/client/pages/about.js 1.05 kB -1 B (0%)
./.nuxt/dist/client/pages/about.modern.js 1.06 kB -2 B (0%)
./.nuxt/dist/client/pages/audio/_id.js 6.63 kB 0 B
./.nuxt/dist/client/pages/audio/_id.modern.js 6.46 kB 0 B
./.nuxt/dist/client/pages/feedback.js 3.23 kB 0 B
./.nuxt/dist/client/pages/feedback.modern.js 3.21 kB 0 B
./.nuxt/dist/client/pages/image/_id.js 6.99 kB 0 B
./.nuxt/dist/client/pages/image/_id.modern.js 6.77 kB +2 B (0%)
./.nuxt/dist/client/pages/index.js 5.05 kB -1 B (0%)
./.nuxt/dist/client/pages/index.modern.js 4.91 kB 0 B
./.nuxt/dist/client/pages/meta-search.js 1.67 kB 0 B
./.nuxt/dist/client/pages/meta-search.modern.js 1.67 kB 0 B
./.nuxt/dist/client/pages/preferences.js 1.21 kB 0 B
./.nuxt/dist/client/pages/preferences.modern.js 1.21 kB -1 B (0%)
./.nuxt/dist/client/pages/search-help.js 1.55 kB 0 B
./.nuxt/dist/client/pages/search-help.modern.js 1.55 kB 0 B
./.nuxt/dist/client/pages/search.js 2.73 kB +1 B (0%)
./.nuxt/dist/client/pages/search.modern.js 2.58 kB -1 B (0%)
./.nuxt/dist/client/pages/search/audio.js 1.19 kB 0 B
./.nuxt/dist/client/pages/search/audio.modern.js 1.2 kB 0 B
./.nuxt/dist/client/pages/search/image.js 2.78 kB 0 B
./.nuxt/dist/client/pages/search/image.modern.js 2.67 kB 0 B
./.nuxt/dist/client/pages/search/index.js 2.99 kB +1 B (0%)
./.nuxt/dist/client/pages/search/index.modern.js 2.96 kB 0 B
./.nuxt/dist/client/pages/search/model-3d.js 242 B +1 B (0%)
./.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.modern.js 270 B 0 B
./.nuxt/dist/client/pages/search/video.js 238 B 0 B
./.nuxt/dist/client/pages/search/video.modern.js 243 B -1 B (0%)
./.nuxt/dist/client/pages/sources.js 1.44 kB 0 B
./.nuxt/dist/client/pages/sources.modern.js 1.45 kB 0 B
./.nuxt/dist/client/vendors/app.js 47.8 kB 0 B
./.nuxt/dist/client/vendors/app.modern.js 47.1 kB 0 B

compressed-size-action

@obulat obulat force-pushed the fix/new_search_type_button branch 2 times, most recently from 89e41c5 to 107cfb0 Compare September 27, 2022 08:29
@obulat obulat force-pushed the add/new_filter_button branch 2 times, most recently from 739c630 to 55a8ac7 Compare September 27, 2022 09:27
@obulat obulat changed the base branch from fix/new_search_type_button to main September 27, 2022 09:27
@obulat obulat marked this pull request as ready for review September 27, 2022 09:41
@obulat obulat requested a review from a team as a code owner September 27, 2022 09:41
@openverse-bot openverse-bot moved this from In progress to Needs review in Openverse PRs Sep 27, 2022
@obulat obulat self-assigned this Sep 27, 2022
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🌟 goal: addition Addition of new feature 🕹 aspect: interface Concerns end-users' experience with the software and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 27, 2022
@obulat obulat mentioned this pull request Sep 27, 2022
Merged
7 tasks
@zackkrida zackkrida requested review from zackkrida and removed request for sarayourfriend September 27, 2022 19:21
@obulat obulat mentioned this pull request Sep 28, 2022
Closed
7 tasks
@obulat obulat changed the title Update the filter button Update the Filters button Sep 28, 2022
@obulat obulat removed this from the Create new header and footer milestone Oct 3, 2022
dhruvkb
dhruvkb approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me!

zackkrida
zackkrida approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks perfect and I love the new tests. I'm actually not sure if we're meant to keep displaying the filter counts on desktop, but @panchovm can answer that on his arrival. LGTM!

Openverse PRs automation moved this from Needs review to Reviewer approved Oct 3, 2022
@obulat
Copy link
Contributor Author

obulat commented Oct 4, 2022

I'm actually not sure if we're meant to keep displaying the filter counts on desktop, but @panchovm can answer that on his arrival.

I'm not sure either. I looked at the Openverse Design library when implementing these, but apparently some components there use old styles. Removing the counts will be easier than adding them in, so :)

@obulat obulat merged commit 908542f into main Oct 4, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Oct 4, 2022
@obulat obulat deleted the add/new_filter_button branch October 4, 2022 03:43
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
@openverse-bot
Clean preview for PR #1861
5afdf6b
@fcoveram fcoveram mentioned this pull request Feb 22, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zackkrida zackkrida zackkrida approved these changes

@dhruvkb dhruvkb dhruvkb approved these changes

Assignees

@obulat obulat

Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents
Projects
No open projects
Openverse PRs
  
Merged!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component: Updated VFilterButton for the desktop header
4 participants
@obulat @zackkrida @dhruvkb @openverse-bot