This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix Audio single result layout #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2006 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
🕹 aspect: interface
|
Size Change: -1.27 kB (0%) Total Size: 853 kB
ℹ️ View Unchanged
|
obulat
force-pushed
the
fix/single_audio_result_layout
branch
from
863fdd3
to
4f497e2
Compare
|
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @zackkrida Excluding weekend1 days, this PR was updated 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes |
obulat
force-pushed
the
fix/single_audio_result_layout
branch
from
4f497e2
to
092203f
Compare
obulat
force-pushed
the
fix/single_audio_result_layout
branch
4 times, most recently
from
930fe64
to
60150ce
Compare
dhruvkb
approved these changes
Dec 6, 2022
| @@ -43,11 +43,13 @@ | |||
| "test:playwright:debug": "PWDEBUG=1 pnpm test:playwright:local", | |||
| "test:playwright:recreate-tapes": "rimraf test/tapes && pnpm test:playwright:update-tapes", | |||
| "test:playwright:update-tapes": "UPDATE_TAPES=true pnpm test:playwright", | |||
| "test:playwright:update-snapshots": "pnpm test:playwright visual-regression --update-snapshots", | |||
There was a problem hiding this comment.
There is some documentation in test/playwright/README.md about using the -u flag that needs to be updated to refer to this script instead.
obulat
force-pushed
the
fix/single_audio_result_layout
branch
from
c63e714
to
5d983bb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2003 by @dhruvkb
Description
This PR fixes the Related audio horizontal padding, and the heading font weights on the single audio result page, and updates the snapshots.
It also adds
defineComponentto theRelatedAudio.Testing Instructions
The snapshots should match the mockups.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin