Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Ping staging deployer in Slack notification #2053

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Conversation

krysal
Copy link
Member

@krysal krysal commented Dec 15, 2022

Fixes

Related to #2052 by @krysal

Description

This PRs updates .github/actions/staging-frontend-deploy/action.yml with the output from terraform.

Let's test on staging first to see if it works correctly, then once confirmed the same changes will be applied to the .github/actions/production-frontend-deploy/action.yml file.

Testing Instructions

Merge and trigger a staging deployment to confirm.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal requested a review from a team as a code owner December 15, 2022 15:51
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Dec 15, 2022
@github-actions
Copy link

github-actions bot commented Dec 15, 2022

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/2053
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2053/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Dec 15, 2022
@krysal krysal added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 15, 2022
@WordPress WordPress deleted a comment from github-actions bot Dec 16, 2022
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see how it works!
I think Zack's note needs to be added in the upstream implementation.

@krysal
Copy link
Member Author

krysal commented Dec 19, 2022

We'll see if this works by merging it right now 🤞

@krysal krysal merged commit 7139171 into main Dec 19, 2022
Openverse PRs automation moved this from Needs review to Merged! Dec 19, 2022
@krysal krysal deleted the update_deploy_action branch December 19, 2022 20:36
github-actions bot pushed a commit that referenced this pull request Dec 19, 2022
krysal added a commit that referenced this pull request Dec 19, 2022
krysal added a commit that referenced this pull request Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

4 participants