Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Upgrade Tailwind to version 3 with JIT mode #540

Merged
merged 3 commits into from Dec 21, 2021
Merged

Upgrade Tailwind to version 3 with JIT mode #540

merged 3 commits into from Dec 21, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Dec 18, 2021

Description

This PR upgrades Tailwind to version 3 with a number of accompanying changes

  • removes the Nuxt Tailwind plugin, which didn't do much and is almost unmaintained
  • enables JIT and removes the explicit variants from the config
  • adjusts code where necessary to address changes between v2 and v3.

Testing Instructions

Run the Storybook and the dev site. If you notice no changes, that means it's working as it should!

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner December 18, 2021 13:57
@dhruvkb dhruvkb added this to Needs review in Openverse PRs Dec 18, 2021
@dhruvkb dhruvkb added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟨 priority: medium Not blocking but should be addressed soon labels Dec 18, 2021
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well! I just have a few questions to clarify.

tailwind.config.js Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the branch locally and I don't think the JIT is working.

I tried adding the example class from the release notes (sm:hover:active:disabled:opacity-75) to an element in the search page and I was unable to get the opacity to apply to it.

I tried this with and without adding the mode option from the release notes, it didn't work either way 😕 But maybe I'm using it wrong? Were you able to confirm it was working somehow?

tailwind.config.js Show resolved Hide resolved
src/constants/screens.js Show resolved Hide resolved
package.json Show resolved Hide resolved
@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 21, 2021

@sarayourfriend I tried the example you mentioned, it worked for me.

Screenshot 2021-12-21 at 1 35 16 PM

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure why I wasn't able to get it to work previously but it works fine now for me, both in storybook and in the actual app.

Openverse PRs automation moved this from Needs review to Reviewer approved Dec 21, 2021
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dhruvkb dhruvkb merged commit 19a5072 into main Dec 21, 2021
Openverse PRs automation moved this from Reviewer approved to Merged! Dec 21, 2021
@dhruvkb dhruvkb deleted the tw3 branch December 21, 2021 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants