Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix homepage accessibility #660

Merged
merged 4 commits into from Jan 21, 2022
Merged

Fix homepage accessibility #660

merged 4 commits into from Jan 21, 2022

Conversation

sarayourfriend
Copy link
Contributor

Fixes

Fixes #652 by @dhruvkb

Description

Switches to a static version of the homepage that randomly selects a set of featured images to show. To avoid creating any accessibility problems with these images, they're wrapped in aria-hidden.

This removes the animated placeholder text. There is an aria-label on the search input that indicates it is for searching.

VInputField's sr-only label element was causing a weird "Safari is busy" bug with VoiceOver. Replacing it with an aria-label has the same effect as the sr-only label element but fixes this bug (I don't know why this bug is happening but we can dig into that a later date).

Testing Instructions

Checkout this branch and run pnpm dev. Visit the site in Safari with VoiceOver and verify that you can successfully navigate the homepage and execute a search.

Note: there are other problems with moving from the homepage to the search results, but I've opened a separate issue to solve those here: #659

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix ♿️ aspect: a11y Concerns related to the project's accessibility labels Jan 20, 2022
@sarayourfriend sarayourfriend requested a review from a team as a code owner January 20, 2022 20:14
@dhruvkb dhruvkb added this to Needs review in Openverse PRs Jan 20, 2022
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this so quickly. Perhaps we can eventually make an improvement where we show the 'featured search' term somewhere else, not related to the input, and get these images cycling again in the short future.

@zackkrida zackkrida requested a review from obulat January 21, 2022 01:29
src/pages/index.vue Show resolved Hide resolved
src/pages/index.vue Outdated Show resolved Hide resolved
src/pages/index.vue Outdated Show resolved Hide resolved
src/pages/index.vue Outdated Show resolved Hide resolved
src/pages/index.vue Show resolved Hide resolved
@fcoveram
Copy link

Can we add a static placeholder that says Search for content? An input without label nor placeholder looks odd.

Openverse PRs automation moved this from Needs review to Reviewer approved Jan 21, 2022
@sarayourfriend sarayourfriend merged commit 52d70db into main Jan 21, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Jan 21, 2022
@sarayourfriend sarayourfriend deleted the fix/homepage-a11y-static branch January 21, 2022 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

Animating the placeholder text on homepage is bad for accessibility
4 participants