This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #652 by @dhruvkb
Description
Switches to a static version of the homepage that randomly selects a set of featured images to show. To avoid creating any accessibility problems with these images, they're wrapped in
aria-hidden
.This removes the animated placeholder text. There is an
aria-label
on the search input that indicates it is for searching.VInputField
'ssr-only
label element was causing a weird "Safari is busy" bug with VoiceOver. Replacing it with anaria-label
has the same effect as thesr-only
label element but fixes this bug (I don't know why this bug is happening but we can dig into that a later date).Testing Instructions
Checkout this branch and run
pnpm dev
. Visit the site in Safari with VoiceOver and verify that you can successfully navigate the homepage and execute a search.Note: there are other problems with moving from the homepage to the search results, but I've opened a separate issue to solve those here: #659
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin