Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove dead a/b testing (sixpack) code #790

Merged
merged 4 commits into from Feb 4, 2022
Merged

Remove dead a/b testing (sixpack) code #790

merged 4 commits into from Feb 4, 2022

Conversation

zackkrida
Copy link
Member

@zackkrida zackkrida commented Feb 3, 2022

Fixes

Fixes #789 by @zackkrida

Description

Removes all code related to the sixpack (a/b testing) module.

Testing Instructions

Observe the tests continue to pass and the application works locally as expected.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner February 3, 2022 03:15
@dhruvkb dhruvkb added this to Needs review in Openverse PRs Feb 3, 2022
@zackkrida zackkrida changed the title Remove dead ab-testing/sixpack code Remove dead a/b testing (sixpack) code Feb 3, 2022
@zackkrida zackkrida added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon labels Feb 3, 2022
@sarayourfriend sarayourfriend added 🟥 priority: critical Must be addressed ASAP and removed 🟨 priority: medium Not blocking but should be addressed soon labels Feb 3, 2022
@sarayourfriend
Copy link
Contributor

Reprioritizing to critical vis-a-vis potential GDPR cookie non-compliance.

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but we should also remove the code here that adds the abSessionId cookie.

@zackkrida
Copy link
Member Author

Such an obvious omission, thanks Sara!

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Openverse PRs automation moved this from Needs review to Reviewer approved Feb 4, 2022
@zackkrida zackkrida merged commit cd20a7e into main Feb 4, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Feb 4, 2022
@zackkrida zackkrida deleted the remove-a-b-code branch February 4, 2022 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

A/B Test Module (aka Sixpack) is no longer in use
3 participants