Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format "Airflow DAG Load Data Complete" duration #1649

Closed
zackkrida opened this issue Feb 23, 2022 · 1 comment · Fixed by WordPress/openverse-catalog#422
Closed

Format "Airflow DAG Load Data Complete" duration #1649

zackkrida opened this issue Feb 23, 2022 · 1 comment · Fixed by WordPress/openverse-catalog#422
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🐍 tech: python Involves Python
Projects

Comments

@zackkrida
Copy link
Member

Description

The notifications are amazing! But currently show the duration in seconds like this:

CleanShot 2022-02-23 at 18 06 05@2x

We might want to:

  • Round
  • Convert to a human readable duration (for example, "47 minutes", "1 hour", or alternatively something like "hh:mm:ss")

This is a very minor concern 😄

Relevant file

https://github.com/WordPress/openverse-catalog/blob/5188b388759a00c42785ca79f0c96949396d4d68/openverse_catalog/dags/common/loader/reporting.py#L18

@zackkrida zackkrida added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🐍 tech: python Involves Python labels Feb 23, 2022
@AetherUnbound
Copy link
Contributor

We'll want to tackle #1645 before this, since duration will be a float after that and will make it easier to round/manipulate.

I think it may also be worth adding a comma separation1 to the record upsert count (e.g. f"Count: {value:,}")

Footnotes

  1. https://docs.python.org/3/library/string.html#format-specification-mini-language

@AetherUnbound AetherUnbound self-assigned this Mar 18, 2022
@dhruvkb dhruvkb added ⛔ status: blocked Blocked & therefore, not ready for work and removed ⛔ status: blocked Blocked & therefore, not ready for work labels Sep 12, 2022
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🐍 tech: python Involves Python
Projects
Archived in project
Openverse
  
Done!
Development

Successfully merging a pull request may close this issue.

3 participants