Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused @types/lodash.sortby package #1930

Closed
sarayourfriend opened this issue Apr 28, 2023 · 0 comments · Fixed by #1937
Closed

Remove unused @types/lodash.sortby package #1930

sarayourfriend opened this issue Apr 28, 2023 · 0 comments · Fixed by #1937
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse

Comments

@sarayourfriend
Copy link
Contributor

Problem

@types/lodash.sortby is installed in the frontend/package.json but lodash.sortBy is not used in our project, nor are these types relied on otherwise.

Description

Remove the @types/lodash.sortby entry from package.json and update the lock file.
@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Apr 28, 2023
@openverse-bot openverse-bot added this to Backlog in Openverse Apr 28, 2023
@wasimTQ wasimTQ mentioned this issue Apr 30, 2023
Merged
8 tasks
Openverse automation moved this from Backlog to Done! May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Openverse
  
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove @types/lodash.sortBy from project wasimTQ/openverse
1 participant
@sarayourfriend