Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"external_sources" feature flag needs to be improved #2138

Closed
obulat opened this issue May 19, 2023 · 0 comments · Fixed by #2141
Closed

"external_sources" feature flag needs to be improved #2138

obulat opened this issue May 19, 2023 · 0 comments · Fixed by #2141
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects

Comments

@obulat
Copy link
Contributor

obulat commented May 19, 2023

Problem

"external_sources" flag name is not very clear, and the External sources popover does not use additional types when this flag is enabled.

Description

I propose renaming the flag to "additional_content_types" as it enables the display of additional types in the content switcher. When this flag is enabled, you should be able to select the external sources for the page's type (even video and model_3d). Now, however, those external sources are never displayed.

Additional context

I discovered the problem that you cannot view the external sources for additional content types when trying to remove the build-url library that's been deprecated. It is used to create the external source URLs with query parameters.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels May 19, 2023
@obulat obulat self-assigned this May 19, 2023
@openverse-bot openverse-bot added this to Backlog in Openverse May 19, 2023
Openverse automation moved this from Backlog to Done! May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Openverse
  
Done!
1 participant