Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent searches popover improvement #3194

Closed
fcoveram opened this issue Oct 16, 2023 · 1 comment · Fixed by #3796
Closed

Recent searches popover improvement #3194

fcoveram opened this issue Oct 16, 2023 · 1 comment · Fixed by #3796
Assignees
Labels
🖼️ aspect: design Concerns related to design 🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🏁 status: ready for work Ready for work

Comments

@fcoveram
Copy link
Contributor

fcoveram commented Oct 16, 2023

Problem

The current recent searches box (VRecentSearches) does not follow the spacing system we defined some time ago. Because of that, the popover looks inconsistent and takes a significant portion of the screen.

Issues related

Proposal

Recent searches box on mobile, tablet, and desktop devices

Description

On xs / sm / md breakpoints

  • Popover box has a padding of 12px for left, right, and bottom.
  • All rows are 40px height, including where title and storing description are.
  • The clear action of an item is always visible.

On lg and beyond

  • Popover box has a padding of 8px for all sides.
  • All rows are 40px height, including where title and storing description are.
  • The clear action of an item shows up during hover state.

The designs include a component state mockup to make more clear how it behaves.

Figma file: Recent searches popover improvement

@fcoveram fcoveram added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 🖼️ aspect: design Concerns related to design labels Oct 16, 2023
@openverse-bot
Copy link
Collaborator

Subscribe to Label Action

cc @WordPress/gutenberg-design, @WordPress/openverse

This issue or pull request has been labeled: "🖼️ aspect: design"

Thus the following users have been cc'd because of the following labels:

  • WordPress/gutenberg-design: 🖼️ aspect: design
  • WordPress/openverse: 🖼️ aspect: design

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@fcoveram fcoveram added 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: frontend Related to the Nuxt frontend design: ready Issue with a mockup ready for implementation labels Oct 16, 2023
@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 16, 2023
@fcoveram fcoveram added the 🏁 status: ready for work Ready for work label Dec 18, 2023
@dhruvkb dhruvkb self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖼️ aspect: design Concerns related to design 🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🏁 status: ready for work Ready for work
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants