Related endpoint returns 500 if the main item is not found in ES index

[obulat]

Problem

For the related endpoint, we first search for the item in ES index to get its title, tags and creator.

openverse/api/api/controllers/elasticsearch/related.py

Line 30 in 5e55faa

item_hit = item_search.query(Term(identifier=uuid)).execute().hits[0]

When the identifier part of the URL matches the UUID regex, but there's no media item with such an identifier, this request doesn't return anything, so this request returns 500 ("Could not find items"). It should return 404 instead, using raise APIException("Not found.", 404)

Description

If the ES request does not return the item, we should return a 404 error.

[ngken0995]

@obulat This might be related to #3520. Here is a comment @dhruvkb wrote. link

[obulat]

You're right, @ngken0995. Thank you for catching this.
Fixed by #3552.