Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong focus style in image component #3525

Open
fcoveram opened this issue Dec 14, 2023 · 0 comments
Open

Wrong focus style in image component #3525

fcoveram opened this issue Dec 14, 2023 · 0 comments
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@fcoveram
Copy link
Contributor

Description

In "All content" and "Image" results, image components have the wrong focus style applied in its large variant. The correct styles are documented in the Design Library. Screenshot attached below.

Design documentation of Image components in Openverse's Design Library

Reproduction

  1. From a laptop or a bigger screen go to Openverse
  2. Search anything and land on "All content" results
  3. Navigate with your keyboard and set the focus on an image result
  4. See the error. Keep navigating until focus on an audio track for comparison of the focus ring.
  5. Repite the process but on step 2 land on "Image" results instead

Screenshots

Image component in "All content" results

Screenshot of All content results with image component focused

Image component in "Images" results

Screenshot of Images results with image component focused

Additional context

If I remember correctly, I started seeing this bug once #2891 was completed. But I might be wrong.
@fcoveram fcoveram added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Dec 14, 2023
@AetherUnbound AetherUnbound added 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend design: ready Issue with a mockup ready for implementation and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fcoveram @AetherUnbound