Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI tests for Python sub-packages #4167

Closed
dhruvkb opened this issue Apr 19, 2024 · 1 comment · Fixed by #4267 or #4266
Closed

Run CI tests for Python sub-packages #4167

dhruvkb opened this issue Apr 19, 2024 · 1 comment · Fixed by #4267 or #4266
Assignees
@dhruvkb
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API 🧱 stack: mgmt Related to repo management and automations 🔧 tech: github actions Involves Github Actions 🐍 tech: python Involves Python
Milestone
Migrate to PDM

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Apr 19, 2024

Problem

PR #4107 adds a new class of Python sub-packages to the monorepo. These packages will have their own test suites. These test suites should run in CI as required checks if their code has changed.

Description

The goal is to
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 🤖 aspect: dx Concerns developers' experience with the codebase 🐍 tech: python Involves Python 🧱 stack: api Related to the Django API 🧱 stack: mgmt Related to repo management and automations 🔧 tech: github actions Involves Github Actions labels Apr 19, 2024
@dhruvkb dhruvkb changed the title Run CI tests for subpackages Run CI tests for Python sub-packages Apr 19, 2024
@dhruvkb dhruvkb mentioned this issue Apr 22, 2024
Merged
8 tasks
@dhruvkb dhruvkb added this to the Migrate to PDM milestone Apr 22, 2024
@dhruvkb dhruvkb self-assigned this Apr 22, 2024
@dhruvkb dhruvkb mentioned this issue May 6, 2024
Merged
8 tasks
@dhruvkb dhruvkb linked a pull request May 6, 2024 that will close this issue
Run checks for Python packages in CI #4267
Merged
8 tasks
@dhruvkb dhruvkb mentioned this issue May 6, 2024
Merged
8 tasks
@dhruvkb
Copy link
Member Author

dhruvkb commented May 6, 2024

This issue was fixed in #4267 which will be merged into main via #4266.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvkb dhruvkb

Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API 🧱 stack: mgmt Related to repo management and automations 🔧 tech: github actions Involves Github Actions 🐍 tech: python Involves Python
Projects
Openverse Backlog
Archived in project
Milestone
Migrate to PDM
1 participant
@dhruvkb