Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude media from sources without ContentProvider record from search #4076

Closed
obulat opened this issue Apr 9, 2024 · 0 comments · Fixed by #4238
Closed

Exclude media from sources without ContentProvider record from search #4076

obulat opened this issue Apr 9, 2024 · 0 comments · Fixed by #4238
Assignees
@krysal
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API

Comments

@obulat
Copy link
Contributor

obulat commented Apr 9, 2024

Problem

When we add a new provider, we don't immediately add a ContentProvider record to the API. This means that the media is immediately available in search results.

Description

When building an excluded source query, we should add the sources that don't have a ContentProvider model to the excluded sources. To do that, we can get all sources using:

openverse/api/api/controllers/search_controller.py

Line 549 in d377c69

def get_sources(index):

This is where the query is built:

openverse/api/api/controllers/search_controller.py

Lines 188 to 193 in d377c69

if not filtered_providers:
filtered_providers = list(
models.ContentProvider.objects.filter(filter_content=True).values_list(
"provider_identifier", flat=True
)
)

Alternatives

An alternative would be to add a step to the data refresh that would add new ContentProvider records for all the sources that were added during the data refresh: #3548

Additional context

#2487 is related in that it added a filter for the single results: if "Hide content" for their provider is set to True, the result is not returned.
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Apr 9, 2024
@krysal krysal mentioned this issue Apr 30, 2024
Merged
8 tasks
@krysal krysal self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krysal krysal

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Openverse Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change search query approach to include only available providers WordPress/openverse
2 participants
@krysal @obulat