Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Media>Decision many-to-many table should reference the media's identifier column, not id #4286

Closed
AetherUnbound opened this issue May 7, 2024 · 0 comments · Fixed by #4310
Closed

<Media>Decision many-to-many table should reference the media's identifier column, not id #4286

AetherUnbound opened this issue May 7, 2024 · 0 comments · Fixed by #4310
Assignees
@AetherUnbound
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API 🔧 tech: django Involves Django
Milestone
Django admin cont...

Comments

@AetherUnbound
Copy link
Contributor

Description

This was originally raised in #4254, and expanded in @sarayourfriend's comment: #4254 (comment)

We will want to change the <Media>Decision models to reference the media's identifier field rather than id in the references. The to_field attribute suggested is not available on Fields, so we'll need to take a different approach. This may require using an explicit table definition.
@AetherUnbound AetherUnbound added 💻 aspect: code Concerns the software code in the repository 🔧 tech: django Involves Django 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API labels May 7, 2024
@AetherUnbound AetherUnbound self-assigned this May 7, 2024
@AetherUnbound AetherUnbound mentioned this issue May 10, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AetherUnbound AetherUnbound

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API 🔧 tech: django Involves Django
Projects
Openverse Backlog
Archived in project
Milestone
Django admin content moderation acces...
Development

Successfully merging a pull request may close this issue.

Use explicit through table for media/decision many-to-many field WordPress/openverse
1 participant
@AetherUnbound