Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to prevent inaccuracies in POT files #454

Open
dhruvkb opened this issue Feb 9, 2023 · 2 comments
Open

Add checks to prevent inaccuracies in POT files #454

dhruvkb opened this issue Feb 9, 2023 · 2 comments
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 💬 talk: discussion Open for discussions and feedback
Projects

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Feb 9, 2023

Problem

Changes to the translation strings and the en.json5 to POT file pipeline can have drastic consequences but those PRs have no specific checks for this POT change associated with them. Once merged, they will irreversibly overwrite the POT file, leading to problems for translators.

Description

If a PR affects the POT file, the diff in the POT should be commented on the PR so that unforeseen negative consequences can be avoided. These checks are similar to the bundle size checks that are run on the frontend PR.

Alternatives

Alternatively, any PR that modifies the en.json5 to POT file pipeline should not be allowed to write to the translation branch but rather make a PR so that the POT changes can be analysed and merged only if correct.

Additional context

This issue came up in a comment WordPress/openverse-frontend#2161 (comment) on PR WordPress/openverse-frontend#2161 which fixes translation issue WordPress/openverse-frontend#2159 as a solution to @krysal's review comment WordPress/openverse-frontend#2161 (review). Alternative approaches welcome.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🌟 goal: addition Addition of new feature 🤖 aspect: dx Concerns developers' experience with the codebase 💬 talk: discussion Open for discussions and feedback labels Feb 9, 2023
@krysal
Copy link
Member

krysal commented Feb 10, 2023

I assume by "inaccuracies" here you mean more like big shift in the POT file, am I right?

Thank you for opening this issue. I think it deserves a higher priority than the lowest.

@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon and removed 🟩 priority: low Low priority and doesn't need to be rushed labels Feb 10, 2023
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@dhruvkb
Copy link
Member Author

dhruvkb commented Nov 24, 2023

@krysal haha yes, but by "inaccuracies" I meant we should also be able to catch even smaller shifts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 💬 talk: discussion Open for discussions and feedback
Projects
Status: 📋 Backlog
Openverse
  
Backlog
Development

No branches or pull requests

3 participants