Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating logo nav component in header #476

Closed
fcoveram opened this issue Dec 26, 2022 · 5 comments · Fixed by #3967
Closed

Updating logo nav component in header #476

fcoveram opened this issue Dec 26, 2022 · 5 comments · Fixed by #3967
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🏁 status: ready for work Ready for work
Projects

Comments

@fcoveram
Copy link
Contributor

fcoveram commented Dec 26, 2022

Problem

In staging, Openverse logo and symbol are used in the Header component, but there are inconsistent sizes and focus styles. I think this happens because the root component is not the same, as VBrand and VLogoLoader do not relate to each other. See the following screenshots from staging environment.

Header

Resting Focus
CleanShot 2022-12-26 at 11 26 37@2x CleanShot 2022-12-26 at 11 26 57@2x

Header internal

Resting Focus
CleanShot 2022-12-26 at 11 27 15@2x CleanShot 2022-12-26 at 11 27 25@2x

Now that we started working on the homepage redesign (#1433) it seems worth improving this key nav element.

Edited version: This update does not affect the Footer component as it uses VBrand for the logo.

Description

Upon the homepage redesign, Logo nav component was updated in Figma to simplify the versions used across the site. Including the homepage and the full-screen menu.

The component has three sizes:

  • Small for the header's small breakpoints where Openverse symbol lives inside the search bar.
  • Medium for the header's large breakpoints where Openverse symbol lives outside the search bar.
  • Large for the header and footer versions where Openverse logo is displayed completely.

And three states: Resting, Hover, Focus, and Loading. The last one is for Small and Medium sizes as those sizes are used in the search flow.

Additional context

This request impacts the subsequent work coming from WordPress/openverse-frontend#1433 as

@fcoveram fcoveram added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature labels Dec 26, 2022
@dhruvkb
Copy link
Member

dhruvkb commented Dec 26, 2022

Linking the PR WordPress/openverse-frontend#2067 here for focus styles.

@fcoveram fcoveram changed the title Updating the Openverse logo nav component Updating logo nav component in header Dec 26, 2022
@fcoveram
Copy link
Contributor Author

The initial ticket mentioned updating the Footer component (done in WordPress/openverse-frontend#2015), but it was a mistake. The request was updated.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🕹 aspect: interface Concerns end-users' experience with the software and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 27, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@zackkrida
Copy link
Member

Here are the current focus states:

CleanShot 2023-02-22 at 10 43 30
CleanShot 2023-02-22 at 10 43 44

Note the full logo is thicker.

@obulat obulat self-assigned this May 19, 2023
@obulat
Copy link
Contributor

obulat commented May 24, 2023

The internal header's logo nav component is fixed in #2136.

The search header's component still needs to be fixed. Here's @fcoveram's comment from #2136 describing the changes required:

is this discrepancy present in Figma? Does it matter to fix this?

As in the example shared, it's not present in Figma. If you go to the Logo nav component in the Design Library, you will see the following

Screenshot of Logo nav component with notes

Row 1 (size: small) is the logo for the content header in small breakpoints when it's part of the search bar. Row 2 (size: medium) is for the content header in bigger breakpoints. And Row 3 (size: large) is for the internal header in all breakpoints.

Row 2 and 3 share the same size for the symbol, but the latter adds the word "openverse" and has a 16px padding on left and right sides.

Medium and Large versions of Logo nav with spacing guides

So going back to your questions from the video:

  • Is this discrepancy present in Figma? The symbol size discrepancy is wrong. The only difference is the padding in row 3 (size: large)
  • Does it matter to fix this? It does. Especially in header content where logo looks bigger than mockups in all breakpoints. See the image below where I compared both headers in their two main variants.

Screenshot of big and small headers in small and big breakpoints

@obulat obulat removed their assignment Jul 12, 2023
@fcoveram fcoveram added the design: ready Issue with a mockup ready for implementation label Jul 28, 2023
@fcoveram
Copy link
Contributor Author

The logo nav update was successfully applied in Header internal in #2136, but the changes described above for Header desktop remain pending.

Can we address this in the next weekly meeting?

@fcoveram fcoveram added the 🏁 status: ready for work Ready for work label Dec 18, 2023
@zackkrida zackkrida self-assigned this Mar 18, 2024
@zackkrida zackkrida mentioned this issue Mar 25, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🏁 status: ready for work Ready for work
Projects
Archived in project
Openverse
  
Backlog
Development

Successfully merging a pull request may close this issue.

4 participants