Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid cookie value causes an error #782

Closed
obulat opened this issue Feb 27, 2023 · 0 comments · Fixed by #798
Closed

Invalid cookie value causes an error #782

obulat opened this issue Feb 27, 2023 · 0 comments · Fixed by #798
Assignees
@dhruvkb
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🐛 tooling: sentry Sentry issue
Projects
Openverse

Comments

@obulat
Copy link
Contributor

obulat commented Feb 27, 2023

Sentry link

https://openverse.sentry.io/share/issue/c41b0e537c444afdaa5e2a8f12f6807e/

Description

TypeError: this.dismissedBanners.includes is not a function is caused by the code that tries to show the translation banner if it hadn't been dismissed when the cookie value is invalid

Reproduction

Go to Openverse.org. Set a numeric value for the uiDismissedBanner cookie, and reload the page. You should see a Nuxt gray error screen.
Screenshot 2023-02-27 at 10 02 09 AM

uiDismissedBanners | 907623
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🐛 tooling: sentry Sentry issue and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Feb 27, 2023
@openverse-bot openverse-bot added this to Backlog in Openverse Feb 27, 2023
@krysal krysal added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 27, 2023
@dhruvkb dhruvkb self-assigned this Feb 28, 2023
@dhruvkb dhruvkb mentioned this issue Feb 28, 2023
Merged
7 tasks
Openverse automation moved this from Backlog to Done! Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvkb dhruvkb

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🐛 tooling: sentry Sentry issue
Projects
Openverse Backlog
Archived in project
Openverse
  
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle incorrect types in cookie value WordPress/openverse
3 participants
@krysal @obulat @dhruvkb