Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Settings language for health checks #326

Closed
mxbclang opened this issue May 4, 2022 · 3 comments · Fixed by #423
Closed

Update Settings language for health checks #326

mxbclang opened this issue May 4, 2022 · 3 comments · Fixed by #423
Assignees
@mxbclang
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Milestone
1.4.0

Comments

@mxbclang
Copy link
Contributor

mxbclang commented May 4, 2022

Feature Description

Currently, the Persistent Object Cache health check is the only one of the four health checks in the plugin that includes that phrase on the Settings screen:

image

The other health checks should be updated to add the word "Health Check" to make them easier to parse without having to read their description text.
@mxbclang mxbclang self-assigned this May 4, 2022
@mxbclang mxbclang added the Infrastructure Issues for the overall performance plugin infrastructure label May 4, 2022
@mxbclang mxbclang added Needs Dev Anything that requires development (e.g. a pull request) [Type] Enhancement A suggestion for improvement of an existing feature labels May 4, 2022
@mukeshpanchal27 mukeshpanchal27 mentioned this issue Jul 13, 2022
Merged
3 tasks
@mukeshpanchal27 mukeshpanchal27 added this to the 1.3.0 milestone Jul 13, 2022
@mukeshpanchal27 mukeshpanchal27 removed the Needs Dev Anything that requires development (e.g. a pull request) label Jul 13, 2022
@mukeshpanchal27
Copy link
Member

I have removed the Needs Dev label as @OllieJones has already submitted a PR for this and also linked the PR to this issue.

@mukeshpanchal27
Copy link
Member

Punting to 1.4.0 as per Felix's comment on PR.

@mukeshpanchal27 mukeshpanchal27 modified the milestones: 1.3.0, 1.4.0 Jul 15, 2022
@felixarntz felixarntz modified the milestones: 1.4.0, 1.5.0 Aug 10, 2022
@felixarntz
Copy link
Member

Fixed via #423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxbclang mxbclang

Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Rename Site Health check modules for language and consistency
3 participants
@felixarntz @mukeshpanchal27 @mxbclang