Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The server performance object-cache.php dropin needs a useful header #615

Closed
OllieJones opened this issue Dec 22, 2022 · 1 comment · Fixed by #649
Closed

The server performance object-cache.php dropin needs a useful header #615

OllieJones opened this issue Dec 22, 2022 · 1 comment · Fixed by #649
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Documentation Documentation to be added or enhanced
Milestone

Comments

@OllieJones
Copy link
Contributor

Bug Description

When Performance Lab is activated, visiting /wp-admin/plugins.php?plugin_status=dropins shows no useful information.

This isn't just a dashboard cosmetic issue; other code that handles drop-ins uses get_plugin_data() to figure out what's going on. The ability to understand the drop-in situation from code will be critical to the success of other drop-ins if this particular hack lives a long time (like hacks tend to do...).

Steps to reproduce

  1. Install and activate some any object cache drop-in.
  2. View the drop-ins via /wp-admin/plugins.php?plugin_status=dropins and observe useful info about the drop-in.
  3. Install and activate Performance Lab.
  4. View the drop-ins via /wp-admin/plugins.php?plugin_status=dropins and observe just rudimentary data.

Additional Context

  • PHP Version: 7.4.3
  • OS: Linux
  • Browser: any
  • Plugin Version: 1.8.0
  • Device: any

Till did a good job of this in the redis object cache. https://github.com/rhubarbgroup/redis-cache/blob/develop/includes/object-cache.php

@OllieJones OllieJones added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure [Focus] Measurement labels Dec 22, 2022
@bethanylang bethanylang added this to Backlog in Infrastructure via automation Jan 3, 2023
@felixarntz felixarntz self-assigned this Feb 1, 2023
@felixarntz felixarntz moved this from Backlog to To do in Infrastructure Feb 1, 2023
@felixarntz felixarntz added [Type] Documentation Documentation to be added or enhanced and removed [Type] Bug An existing feature is broken labels Feb 1, 2023
@felixarntz felixarntz added this to the 2.0.0 milestone Feb 1, 2023
@felixarntz
Copy link
Member

Thanks @OllieJones, I'll work on enhancing this. I keep forgetting that having a plugin header on drop-ins actually helps. Great catch!

@felixarntz felixarntz moved this from To do to In progress in Infrastructure Feb 11, 2023
@felixarntz felixarntz moved this from In progress to Review in Infrastructure Feb 11, 2023
@felixarntz felixarntz removed their assignment Feb 11, 2023
Infrastructure automation moved this from Review to Done Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Documentation Documentation to be added or enhanced
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants