Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file header to object-cache drop-in to clarify purpose #649

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Add file header to object-cache drop-in to clarify purpose #649

merged 2 commits into from
Feb 14, 2023

Conversation

felixarntz
Copy link
Member

Summary

Fixes #615

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Documentation Documentation to be added or enhanced Infrastructure Issues for the overall performance plugin infrastructure labels Feb 11, 2023
@felixarntz felixarntz added this to the 2.0.0 milestone Feb 11, 2023
@felixarntz felixarntz added the Needs Review Anything that requires code review label Feb 11, 2023
mukeshpanchal27
mukeshpanchal27 reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixarntz, The changes look solid to me. Left few suggestions.

server-timing/object-cache.copy.php Show resolved Hide resolved
server-timing/object-cache.copy.php Show resolved Hide resolved
mukeshpanchal27
mukeshpanchal27 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixarntz, LGTM!

@felixarntz
Copy link
Member Author

@OllieJones @joemcgill Can one of you please give this a 2nd pass and approval when you have a second?

OllieJones
OllieJones approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@OllieJones OllieJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks exactly right to me. Thanks!

@felixarntz felixarntz merged commit 40e7dd5 into trunk Feb 14, 2023
@felixarntz felixarntz deleted the add/615-object-cache-dropin-header branch February 14, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OllieJones OllieJones OllieJones approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@vishalkakadiya vishalkakadiya Awaiting requested review from vishalkakadiya

@joemcgill joemcgill Awaiting requested review from joemcgill

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure Needs Review Anything that requires code review [Type] Documentation Documentation to be added or enhanced
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

The server performance object-cache.php dropin needs a useful header
3 participants
@felixarntz @OllieJones @mukeshpanchal27