Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test for Multisite #1014

Merged
merged 1 commit into from Feb 26, 2024

Conversation

mukeshpanchal27
Copy link
Member

Summary

In #956, we introduced a test suite for plugins, updating only the phpunit.xml.dist file. However, we missed updating the multisite config file tests/multisite.xml, causing it to show "No tests executed!" without an error. This PR adds the missing configuration for the multisite test suite. Thanks to @thelovekesh for spotting this oversight.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release Creating standalone plugins labels Feb 26, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Feb 26, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review February 26, 2024 05:36
Copy link

github-actions bot commented Feb 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@thelovekesh
Copy link
Member

Note: As discovered in #1013, wp-env based setup has some issues(#1013 (comment)). Since it's a docker-based setup we don't have much control over it. So in the same PR, I have updated the wp-env based setup with a more controllable and super-fast setup which simulates real scenario WordPress setup.

@swissspidy swissspidy merged commit 082a106 into feature/modules-to-plugins Feb 26, 2024
39 checks passed
@swissspidy swissspidy deleted the fix/test-suite-for-multisite branch February 26, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Creating standalone plugins Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants