Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade notice to inform users of major change prior to 3.0.0 update #1019

Merged
merged 4 commits into from Mar 6, 2024

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #655

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Documentation Documentation to be added or enhanced Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release Creating standalone plugins labels Feb 28, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Feb 28, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review February 28, 2024 08:39
Copy link

github-actions bot commented Feb 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

readme.txt Outdated Show resolved Hide resolved
Co-authored-by: Pascal Birchler <pascalb@google.com>
readme.txt Outdated Show resolved Hide resolved
@felixarntz
Copy link
Member

Please take a look at #656 (comment) where we can coordinate the next steps on how to proceed with this PR and #1011.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Thanks, this looks good to me, pending @westonruter's suggestion.

I'm putting a "request changes" similar to #1011, just until we decide how to proceed with this. See my above comment.

Co-authored-by: Weston Ruter <westonruter@google.com>
@felixarntz felixarntz changed the base branch from feature/modules-to-plugins to trunk March 2, 2024 02:52
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 LGTM, though we should probably merge #1011 first.

@felixarntz felixarntz merged commit 811e8c6 into trunk Mar 6, 2024
8 checks passed
@felixarntz felixarntz deleted the fix/655-add-upgrade-notice branch March 6, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Creating standalone plugins Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Documentation Documentation to be added or enhanced
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add upgrade notice to inform users of major change prior to 3.0.0 update
5 participants