Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get-plugin-dir command for plugins #1026

Merged
merged 2 commits into from Mar 5, 2024
Merged

Conversation

mukeshpanchal27
Copy link
Member

Summary

Follow-up #1000

In the changes made in 15b1cc0, we simplified the commands get-plugin-dir and get-plugin-version. However, when we run node ./bin/plugin/cli.js get-plugin-version --slug=auto-sizes for the manual workflow, it shows an error: Error: The "auto-sizes" module/plugin slug is missing in the file.

This PR resolves that issue.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release Creating standalone plugins labels Mar 5, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Mar 5, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review March 5, 2024 15:54
Copy link

github-actions bot commented Mar 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Good catch!

@felixarntz felixarntz merged commit 646116b into trunk Mar 5, 2024
21 checks passed
@felixarntz felixarntz deleted the fix/get-plugin-dir-command branch March 5, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Creating standalone plugins Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants