Update Embed Optimizer to be standalone plugin (along with merge from trunk) #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge trunk into feature/modules-to-plugins
Add test suite for Plugins folder
Merge trunk into auto-sizes
Fix unit test for `feature/auto-sizes` branch
Force HTML5 script theme support when printing JSON script
Co-authored-by: Joe McGill <801097+joemcgill@users.noreply.github.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
…com:WordPress/performance into enhance/server-timing-dropin-update-support
…update-support Enhance `object-cache.php` drop-in placement logic to support updating to a newer version of the file
… update/embed-optimizer-standalone-plugin
westonruter
added
[Type] Enhancement
westonruter
requested review from
pbearne,
spacedmonkey,
manuelRod,
felixarntz,
adamsilverstein and
mukeshpanchal27
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @shailm@itpathsolutions.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
plugins/embed-optimizer/load.php
Outdated
| <?php | ||
| /** | ||
| * Plugin Name: Embed Optimizer | ||
| * Plugin URI: https://github.com/WordPress/performance/issues/888 |
There was a problem hiding this comment.
Suggested change
| * Plugin URI: https://github.com/WordPress/performance/issues/888 | |
| * Plugin URI: https://github.com/WordPress/performance/tree/trunk/plugins/embed-optimizer |
plugins/embed-optimizer/readme.txt
Outdated
| Stable tag: 0.1.0 | ||
| License: GPLv2 or later | ||
| License URI: https://www.gnu.org/licenses/gpl-2.0.html | ||
| Tags: performance, images |
There was a problem hiding this comment.
Tags should be changed for this plugin embeds?
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
mukeshpanchal27
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beyond just merging
trunkintofeature/lazy-embeds(b764417), this PR then applies the following changes (b764417...61ad495) to complete the change from a module to a plugin.Compare diff with
trunk: 7ba61f4...61ad495 (changes).