Add generator meta tag for Embed Optimizer #1057
Conversation
westonruter
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Adam Silverstein <adamjs@google.com>
| if ( | ||
| defined( 'EMBED_OPTIMIZER_VERSION' ) | ||
| ) { |
There was a problem hiding this comment.
This condition seems pointless if we always define the constant. But it is present in the other plugins.
There was a problem hiding this comment.
🤷🏼 very defensive coding
There was a problem hiding this comment.
Maybe we should also check if esc_attr() exists and wrap it in a try/catch block then 😄
| * | ||
| * @covers ::embed_optimizer_render_generator | ||
| */ | ||
| public function test_embed_optimizer_render_generator() { |
This matches the
meta[name=generator]added by WebP Uploads and Dominant Color Images.