New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Embed Optimizer assets and update readme #1066
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
plugins/embed-optimizer/load.php
Outdated
@@ -2,7 +2,7 @@ | |||
/** | |||
* Plugin Name: Embed Optimizer | |||
* Plugin URI: https://github.com/WordPress/performance/tree/trunk/plugins/embed-optimizer | |||
* Description: Optimize the performance of embeds. | |||
* Description: Optimize the performance of embeds by lazy-loading them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1046 (comment) proposes Optimizes the performance of embeds by lazy-loading iframes and scripts.
.
Doesn't mean we have to go with that, but let's align this. At the very minimum, this needs to be changed to use a third-person verb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 175e2ea
Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Updating assets and readme for initial commit on WordPress.org.