Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Embed Optimizer assets and update readme #1066

Merged
merged 3 commits into from Mar 20, 2024

Conversation

westonruter
Copy link
Member

Updating assets and readme for initial commit on WordPress.org.

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] JS & CSS Issues related to the JS & CSS focus area (formerly JavaScript) no milestone PRs that do not have a defined milestone for release [Plugin] Embed Optimizer Issues for the Embed Optimizer plugin labels Mar 20, 2024
Copy link

github-actions bot commented Mar 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@@ -2,7 +2,7 @@
/**
* Plugin Name: Embed Optimizer
* Plugin URI: https://github.com/WordPress/performance/tree/trunk/plugins/embed-optimizer
* Description: Optimize the performance of embeds.
* Description: Optimize the performance of embeds by lazy-loading them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1046 (comment) proposes Optimizes the performance of embeds by lazy-loading iframes and scripts..

Doesn't mean we have to go with that, but let's align this. At the very minimum, this needs to be changed to use a third-person verb.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 175e2ea

plugins/embed-optimizer/readme.txt Outdated Show resolved Hide resolved
Co-authored-by: felixarntz <flixos90@git.wordpress.org>
@westonruter westonruter merged commit 7854297 into feature/lazy-embeds Mar 20, 2024
38 checks passed
@westonruter westonruter deleted the add/embed-optimizer-assets branch March 20, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] JS & CSS Issues related to the JS & CSS focus area (formerly JavaScript) no milestone PRs that do not have a defined milestone for release [Plugin] Embed Optimizer Issues for the Embed Optimizer plugin [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants