Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename object-caching to object-cache #108

Merged
merged 3 commits into from Jan 28, 2022
Merged

Conversation

tillkruss
Copy link
Member

@tillkruss tillkruss commented Jan 19, 2022

Summary

WordPress core calls it "Object Cache" not "Object Caching".

Also replaced @dustinrue with @spacedmonkey as code owner, if that's cool?

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

for consistency with WordPress core; add @spacedmonkey as code owner
@tillkruss tillkruss added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Jan 19, 2022
@tillkruss tillkruss added this to the 1.0.0-beta.1 milestone Jan 19, 2022
@tillkruss tillkruss added this to Backlog in Infrastructure via automation Jan 19, 2022
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I'd prefer if we can hold off a few more days with merging this - see my comments below.

# Focus: Object Cache
/modules/object-cache @tillkruss @spacedmonkey
/tests/modules/object-cache @tillkruss @spacedmonkey
/tests/testdata/modules/object-cache @tillkruss @spacedmonkey
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait with this change just a little more until we've confirmed. If/once we merge this, we also need to update e.g. the spreadsheet with our PoCs accordingly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's confirmed.

Screen Shot 2022-01-25 at 8 49 57 AM

/tests/modules/object-caching @tillkruss @dustinrue
/tests/testdata/modules/object-caching @tillkruss @dustinrue
# Focus: Object Cache
/modules/object-cache @tillkruss @spacedmonkey
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - let's make sure to also update this elsewhere though, e.g. the GitHub label and our focus area organization spreadsheet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already updated the labels and project in the repo. @bethanylang Where else would this need updating?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixarntz
Copy link
Member

Excellent, updated the focus area name in the spreadsheet now as well.

@felixarntz felixarntz merged commit 5625ad8 into trunk Jan 28, 2022
Infrastructure automation moved this from Backlog to Done Jan 28, 2022
@tillkruss tillkruss deleted the fix/rename-object-caching branch March 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants