Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin names and descriptions to better describe their features #1101

Merged
merged 4 commits into from Mar 29, 2024

Conversation

felixarntz
Copy link
Member

Summary

Fixes #1046 (note that the prefixing discussion and implementation should be part of a separate issue)

This is a sub PR of #1100. Please merge that one first.

Relevant technical choices

Copy link

github-actions bot commented Mar 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>
Co-authored-by: ThierryA <tweetythierry@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

License: GPLv2 or later
License URI: https://www.gnu.org/licenses/gpl-2.0.html
Tags: performance, images, dominant color

Adds support to store the dominant color of newly uploaded images and create a placeholder background of that color.
Displays placeholders based on an image's dominant color while the image is loading.

== Description ==
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the first line of the description should say:

This plugin was formerly known as Dominant Color Images.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter How about putting those explanations at the end of the respective == Description == section?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 0c04a92

@@ -9,15 +9,15 @@ License: GPLv2 or later
License URI: https://www.gnu.org/licenses/gpl-2.0.html
Tags: performance, javascript, speculation rules, prerender, prefetch

Uses the Speculation Rules API to prerender linked URLs upon hover by default.
Enables browsers to speculatively prerender or prefetch pages when hovering over links.

== Description ==
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto above about mentioning the old name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 0c04a92

License: GPLv2 or later
License URI: https://www.gnu.org/licenses/gpl-2.0.html
Tags: performance, images, webp

Creates WebP versions for new JPEG image uploads if supported by the server.
Converts images to more modern formats such as WebP or AVIF during upload.

== Description ==
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto above about mentioning the old name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 0c04a92

Base automatically changed from cleanup/module-references to trunk March 29, 2024 15:28
@felixarntz felixarntz added [Type] Documentation Documentation to be added or enhanced Infrastructure Issues for the overall performance plugin infrastructure Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only skip changelog PRs that should not be mentioned in changelogs labels Mar 29, 2024
@felixarntz felixarntz added this to the performance-lab 3.0.0 milestone Mar 29, 2024
@felixarntz felixarntz merged commit 82bd7fc into trunk Mar 29, 2024
25 checks passed
@felixarntz felixarntz deleted the update/1046-plugin-names branch March 29, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only skip changelog PRs that should not be mentioned in changelogs [Type] Documentation Documentation to be added or enhanced
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review current plugin names and their descriptions for their accuracy and helpfulness
3 participants