Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-sizes generator tag. #1105

Merged
merged 4 commits into from Apr 2, 2024
Merged

Conversation

felixarntz
Copy link
Member

Summary

This PR adds a generator meta tag to the remaining plugin that didn't have one yet, auto-sizes. Per #1103, it uses the immutable plugin slug for it.

This will be included in the 1.0.1 version (for which the codebase has already been bumped before).

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images Issues related to the Images focus area [Plugin] Auto Sizes Issues for the Auto Sizes plugin labels Apr 1, 2024
@felixarntz felixarntz added this to the auto-sizes 1.0.1 milestone Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Pre-approving with one suggestion.

*
* @covers ::auto_sizes_render_generator
*/
public function test_auto_sizes_render_generator() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be for adding an additional test to ensure this callback is properly hooked to the wp_head action, similar to this example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, we can add this here. Though then I'd say lets also assert the other hooks in the same test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 1a70161

@felixarntz
Copy link
Member Author

There's an unrelated "Spell Check" CI failure here now, for which I opened #1106. Please take a look.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @felixarntz!

@mukeshpanchal27
Copy link
Member

There's an unrelated "Spell Check" CI failure here now, for which I opened #1106. Please take a look.

The PR has been merged now, and the CI failure has also been fixed in this branch. It's ready for merge.

@mukeshpanchal27 mukeshpanchal27 merged commit 9531bb2 into trunk Apr 2, 2024
26 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the add/auto-sizes-generator-tag branch April 2, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Images Issues related to the Images focus area [Plugin] Auto Sizes Issues for the Auto Sizes plugin [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants