New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-sizes generator tag. #1105
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Pre-approving with one suggestion.
* | ||
* @covers ::auto_sizes_render_generator | ||
*/ | ||
public function test_auto_sizes_render_generator() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be for adding an additional test to ensure this callback is properly hooked to the wp_head
action, similar to this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, we can add this here. Though then I'd say lets also assert the other hooks in the same test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 1a70161
There's an unrelated "Spell Check" CI failure here now, for which I opened #1106. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @felixarntz!
The PR has been merged now, and the CI failure has also been fixed in this branch. It's ready for merge. |
Summary
This PR adds a generator meta tag to the remaining plugin that didn't have one yet,
auto-sizes
. Per #1103, it uses the immutable plugin slug for it.This will be included in the 1.0.1 version (for which the codebase has already been bumped before).