Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release instructions to include proper branching strategy and protect release branches #221

Merged
merged 3 commits into from Mar 14, 2022
Merged

Update release instructions to include proper branching strategy and protect release branches #221

merged 3 commits into from Mar 14, 2022

Conversation

felixarntz
Copy link
Member

Summary

Fixes #214

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Documentation Documentation to be added or enhanced Infrastructure Issues for the overall performance plugin infrastructure Needs Review Anything that requires code review labels Mar 8, 2022
@felixarntz felixarntz added this to the 1.0.0-beta.2 milestone Mar 8, 2022
@felixarntz felixarntz mentioned this pull request Mar 8, 2022
Closed
dainemawer
dainemawer approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@dainemawer dainemawer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixarntz left a few comments, approving regardless :)

docs/Releasing-the-plugin.md Outdated Show resolved Hide resolved
docs/Releasing-the-plugin.md Show resolved Hide resolved
docs/Releasing-the-plugin.md Show resolved Hide resolved
JustinyAhin
JustinyAhin approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@JustinyAhin JustinyAhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions @felixarntz.

@felixarntz felixarntz merged commit 97573d8 into trunk Mar 14, 2022
@felixarntz felixarntz deleted the update/release-instructions branch April 15, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dainemawer dainemawer dainemawer approved these changes

@JustinyAhin JustinyAhin JustinyAhin approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@jeffpaul jeffpaul Awaiting requested review from jeffpaul

@bethanylang bethanylang Awaiting requested review from bethanylang

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure Needs Review Anything that requires code review [Type] Documentation Documentation to be added or enhanced
Projects
None yet
Milestone
1.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

Update release documentation to separate release branch creation from release day process
3 participants
@felixarntz @JustinyAhin @dainemawer