Adds sources information to the attachment media details of the REST response

[eugene-manuilov]

Summary

Fixes #167

Relevant technical choices

Checklist

• PR has either [Focus] or Infrastructure label.
• PR has a [Type] label.
• PR has a milestone or the no milestone label.

[mitogh]

Great work on this one, few minor comments/questions.

[mitogh]

Curios about the need for this conditional if the file key is not accessed in this function.

[eugene-manuilov]

Just a concise way to ensure that the metadata array contains data that belongs to an image.

[mitogh]

I'm not sure if it follow that part, I think this sectionof code is not required due you already have this section in place few lines below:

if ( ! isset( $data['media_details']['sizes'] ) || ! is_array( $data['media_details']['sizes'] ) ) {

Which already covers that scenario.

[felixarntz]

I agree that check here looks unnecessary. A more appropriate check if we want to avoid running the following logic unnecessarily may be empty( $metadata['sizes'] ) for example.

[eugene-manuilov]

@mitogh @felixarntz ok, this check is removed. 👍

[felixarntz]

@eugene-manuilov Nothing to add from my end other than what @mitogh has already commented on. Other than that, this looks solid 👍

[felixarntz]

One minor comment, but overall lgtm!

[felixarntz]

I agree that check here looks unnecessary. A more appropriate check if we want to avoid running the following logic unnecessarily may be empty( $metadata['sizes'] ) for example.

[mitogh]

👍