-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore and backup image sizes alongside the sources properties #242
Restore and backup image sizes alongside the sources properties #242
Commits on Mar 19, 2022
-
Add class to mimic image operations on the editor.
The class is in charge of performing operations to an image as if a user is performing those actions from the image editor but from the BE. This class is a utility class to be used from within the test context to mimic the user behavior of performing edits into an image.
Configuration menu - View commit details
-
Copy full SHA for a6f5e07 - Browse repository at this point
Copy the full SHA a6f5e07View commit details -
Restore and backup image sizes including
sources
.When an image is edited the `sources` properties is going to be backup with the rest of the sizes properties, however that's not the case for the `full` size which is a virtual type and the top level `sources` would be moved into the backup metadata. When the image is restored any edited image available in the sources array would be removed before the restore takes place. The `sources` property for the `full-orig` would be placed at the top level `sources` with the rest of the metadata.
Configuration menu - View commit details
-
Copy full SHA for 4820501 - Browse repository at this point
Copy the full SHA 4820501View commit details
Commits on Mar 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ab7bf05 - Browse repository at this point
Copy the full SHA ab7bf05View commit details
Commits on Mar 23, 2022
-
Remove handling of edited images
This would be handled once #158 is merged so the current approach can be adjusted accordingly.
Configuration menu - View commit details
-
Copy full SHA for 7e82041 - Browse repository at this point
Copy the full SHA 7e82041View commit details -
Update the
success
logic to handle additional cases.When an image is edited using a target other than the all and the thumbnail make sure the `success` method returns the correct value.
Configuration menu - View commit details
-
Copy full SHA for a2b82e3 - Browse repository at this point
Copy the full SHA a2b82e3View commit details -
Update logic to store and restore backup.
Due to the only value that is not correctly stored is the top level sources attributes this now is stored in a separate meta value. Stored in `_wp_attachment_backup_sources` Logic was added to handle scenarios where only the thumbnail or all images except the thumbnail are modified.
Configuration menu - View commit details
-
Copy full SHA for ba0cbdf - Browse repository at this point
Copy the full SHA ba0cbdfView commit details -
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2dd29d8 - Browse repository at this point
Copy the full SHA 2dd29d8View commit details -
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b16cee1 - Browse repository at this point
Copy the full SHA b16cee1View commit details -
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8a8e967 - Browse repository at this point
Copy the full SHA 8a8e967View commit details -
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 322dd3d - Browse repository at this point
Copy the full SHA 322dd3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 226a5aa - Browse repository at this point
Copy the full SHA 226a5aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a809ed - Browse repository at this point
Copy the full SHA 8a809edView commit details
Commits on Mar 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6d134e5 - Browse repository at this point
Copy the full SHA 6d134e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76307e6 - Browse repository at this point
Copy the full SHA 76307e6View commit details
Commits on Mar 26, 2022
-
Remove the need of auxilary variable to hold the sources
Move the hooks for the update right into the place where they are actually used.
Configuration menu - View commit details
-
Copy full SHA for 951c4ca - Browse repository at this point
Copy the full SHA 951c4caView commit details
Commits on Mar 28, 2022
-
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 61e25e8 - Browse repository at this point
Copy the full SHA 61e25e8View commit details -
Align parameters on the doc block
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 4c26f4f - Browse repository at this point
Copy the full SHA 4c26f4fView commit details -
Removal of non required parameter
The `backup_sizes` parameter was not used so it can be safely removed from the code execution.
Configuration menu - View commit details
-
Copy full SHA for 973a7b8 - Browse repository at this point
Copy the full SHA 973a7b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb35f42 - Browse repository at this point
Copy the full SHA cb35f42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7880f6b - Browse repository at this point
Copy the full SHA 7880f6bView commit details -
Move logic of the hook into a variable
Reuse the hook as now is stored in a variable, so it can be reused in both hooks.
Configuration menu - View commit details
-
Copy full SHA for ca8d28e - Browse repository at this point
Copy the full SHA ca8d28eView commit details
Commits on Mar 30, 2022
-
Co-authored-by: Eugene Manuilov <manuilov@google.com>
Configuration menu - View commit details
-
Copy full SHA for c381398 - Browse repository at this point
Copy the full SHA c381398View commit details -
Co-authored-by: Eugene Manuilov <manuilov@google.com>
Configuration menu - View commit details
-
Copy full SHA for 93e0d01 - Browse repository at this point
Copy the full SHA 93e0d01View commit details -
Removal of
sanitize_text_field
due this value is not required.Co-authored-by: Eugene Manuilov <manuilov@google.com>
Configuration menu - View commit details
-
Copy full SHA for c165a11 - Browse repository at this point
Copy the full SHA c165a11View commit details -
Run logic only if was executed when doing ajax.
Co-authored-by: Eugene Manuilov <manuilov@google.com>
Configuration menu - View commit details
-
Copy full SHA for 7d96583 - Browse repository at this point
Copy the full SHA 7d96583View commit details -
Update code flow for more performant checks
Make sure the code performns in a more structured way
Configuration menu - View commit details
-
Copy full SHA for 7a113d3 - Browse repository at this point
Copy the full SHA 7a113d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e202548 - Browse repository at this point
Copy the full SHA e202548View commit details -
Configuration menu - View commit details
-
Copy full SHA for 188c7df - Browse repository at this point
Copy the full SHA 188c7dfView commit details